Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(7)

Issue 11316284: Boost WaveOut thread priority for background audio. (Closed)

Created:
6 years, 4 months ago by DaleCurtis
Modified:
6 years, 4 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Boost WaveOut thread priority for background audio. XP seems to be lowering the priority of the thread responding to audio callbacks when backgrounded, causing glitching. BUG=161307 TEST=background playback on XP works without issue. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170870

Patch Set 1 : Typo. #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M media/audio/win/waveout_output_win.cc View 2 chunks +7 lines, -0 lines 3 comments Download

Messages

Total messages: 12 (0 generated)
DaleCurtis
No more glitching! AudioDeviceThread is created with kThreadPriority_RealtimeAudio, so it's possible we should just set ...
6 years, 4 months ago (2012-11-30 22:07:04 UTC) #1
scherkus (not reviewing)
https://codereview.chromium.org/11316284/diff/2001/media/audio/win/waveout_output_win.cc File media/audio/win/waveout_output_win.cc (right): https://codereview.chromium.org/11316284/diff/2001/media/audio/win/waveout_output_win.cc#newcode114 media/audio/win/waveout_output_win.cc:114: // Boost thread priority. Required for glitch free background ...
6 years, 4 months ago (2012-11-30 22:13:34 UTC) #2
DaleCurtis
It's just the thread created by the AudioManager, not the threads in the OS thread ...
6 years, 4 months ago (2012-11-30 22:45:23 UTC) #3
scherkus (not reviewing)
On 2012/11/30 22:45:23, DaleCurtis wrote: > It's just the thread created by the AudioManager, not ...
6 years, 4 months ago (2012-11-30 22:59:14 UTC) #4
DaleCurtis
On 2012/11/30 22:59:14, scherkus wrote: > On 2012/11/30 22:45:23, DaleCurtis wrote: > > It's just ...
6 years, 4 months ago (2012-11-30 23:05:07 UTC) #5
scherkus (not reviewing)
On 2012/11/30 23:05:07, DaleCurtis wrote: > On 2012/11/30 22:59:14, scherkus wrote: > > On 2012/11/30 ...
6 years, 4 months ago (2012-11-30 23:05:59 UTC) #6
scherkus (not reviewing)
ignore my comments about BufferCallback() -- I have no idea how/why I thought I saw ...
6 years, 4 months ago (2012-11-30 23:12:31 UTC) #7
scherkus (not reviewing)
lgtm
6 years, 4 months ago (2012-12-01 00:10:33 UTC) #8
henrika (OOO until Aug 14)
LGTM. Even if it always feels a bit scary if a thread prio really does ...
6 years, 4 months ago (2012-12-03 08:35:43 UTC) #9
DaleCurtis
https://chromiumcodereview.appspot.com/11316284/diff/2001/media/audio/win/waveout_output_win.cc File media/audio/win/waveout_output_win.cc (right): https://chromiumcodereview.appspot.com/11316284/diff/2001/media/audio/win/waveout_output_win.cc#newcode114 media/audio/win/waveout_output_win.cc:114: // Boost thread priority. Required for glitch free background ...
6 years, 4 months ago (2012-12-03 18:11:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/11316284/2001
6 years, 4 months ago (2012-12-03 19:38:32 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2012-12-04 02:02:56 UTC) #12
Retried try job too often on mac_rel for step(s) browser_tests

Powered by Google App Engine
This is Rietveld 408576698