Issue 11316270: SyncFileSystem: Register origin only after the local-side initialization finishes successfully

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11316270: SyncFileSystem: Register origin only after the local-side initialization finishes successfully (Closed)

Created:
8 years ago by kinuko

Modified:
8 years ago

Reviewers:
nhiroki, tzik

CC:
chromium-reviews, tzik+watch_chromium.org, kinuko+watch, calvinlo

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

SyncFileSystem: Register origin only after the local-side initialization finishes successfully Two reasons to do this: - We should prevent LocalFileSystemService's RemoteChangeProcessor methods from being called for origins that may not have been initialized in the local side yet. (If we run the initialization simultaneously it's not straightforward to disallow this) - It's not easy to undo the RegisterOrigin if local-side's initialization fails. BUG=none TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170716

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -9 lines)			Patch
	M	chrome/browser/sync_file_system/sync_file_system_service.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	chrome/browser/sync_file_system/sync_file_system_service.cc	View		2 chunks	+21 lines, -9 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kinuko

Will be submitting as this'd be a simple change... Taiju, please feel free to shout ...

8 years ago (2012-12-03 06:11:18 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/11316270/1

8 years ago (2012-12-03 06:11:35 UTC) #4

LGTM. Sorry for slow review..

Expand Messages | Collapse Messages