Issue 11316265: Quota calculation is wrong in cross-filesystem operation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11316265: Quota calculation is wrong in cross-filesystem operation (Closed)

Created:
8 years ago by kinuko

Modified:
8 years ago

Reviewers:
tzik

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, kinuko+watch, jam, tzik+watch_chromium.org, nhiroki

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Quota calculation is wrong in cross-filesystem operation We fire update/change notifications to the observers attached to the FileSystemOperationContext, but the current code creates a new FileSystemOperation (and thus FileSystemOperationContext) for the source URL. This results in no update/change modifications in the destination filesystem in cross-filesystem operation cases. BUG=163540 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170428

Patch Set 1 #

Total comments: 1

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -17 lines)			Patch
M	content/browser/fileapi/fileapi_message_filter.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	webkit/fileapi/file_system_usage_cache.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/fileapi/local_file_system_operation.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	webkit/fileapi/local_file_system_operation.cc	View	6 chunks	+22 lines, -14 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tzik

8 years ago (2012-11-30 07:00:44 UTC) #2

lgtm

https://codereview.chromium.org/11316265/diff/1/webkit/fileapi/local_file_sys...
File webkit/fileapi/local_file_system_operation.cc (right):

https://codereview.chromium.org/11316265/diff/1/webkit/fileapi/local_file_sys...
webkit/fileapi/local_file_system_operation.cc:152: // (See
http://crbug.com/130055)
Could you update the issue?

Expand Messages | Collapse Messages