Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Issue 11316262: google_apis: Move AuthOperation to auth_service.cc (Closed)

Created:
8 years ago by satorux1
Modified:
8 years ago
Reviewers:
kinaba
CC:
chromium-reviews, achuith+watch_chromium.org
Visibility:
Public.

Description

google_apis: Move AuthOperation to auth_service.cc AuthOperation was only used in auth_service, hence there is no need to have this class in base_operations.h Along the way, remove an unused function Authenticate() from OperationRunner, and make some functions private there. Remove AuthenticateStub from MockDriveService as well. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170399

Patch Set 1 #

Patch Set 2 : reorder headers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -137 lines) Patch
M chrome/browser/google_apis/auth_service.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/google_apis/auth_service.cc View 1 3 chunks +112 lines, -0 lines 0 comments Download
M chrome/browser/google_apis/base_operations.h View 1 chunk +0 lines, -34 lines 0 comments Download
M chrome/browser/google_apis/base_operations.cc View 4 chunks +0 lines, -81 lines 0 comments Download
M chrome/browser/google_apis/mock_drive_service.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/google_apis/mock_drive_service.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/google_apis/operation_runner.h View 3 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/google_apis/operation_runner.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
satorux1
8 years ago (2012-11-30 01:50:28 UTC) #1
kinaba
8 years ago (2012-11-30 02:04:05 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698