Issue 11316262: google_apis: Move AuthOperation to auth_service.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11316262: google_apis: Move AuthOperation to auth_service.cc (Closed)

Created:
8 years ago by satorux1

Modified:
8 years ago

Reviewers:
kinaba

CC:
chromium-reviews, achuith+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

google_apis: Move AuthOperation to auth_service.cc AuthOperation was only used in auth_service, hence there is no need to have this class in base_operations.h Along the way, remove an unused function Authenticate() from OperationRunner, and make some functions private there. Remove AuthenticateStub from MockDriveService as well. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170399

Patch Set 1 #

Patch Set 2 : reorder headers #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+118 lines, -137 lines)			Patch
M	chrome/browser/google_apis/auth_service.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/google_apis/auth_service.cc	View	1	3 chunks	+112 lines, -0 lines	0 comments	Download
M	chrome/browser/google_apis/base_operations.h	View		1 chunk	+0 lines, -34 lines	0 comments	Download
M	chrome/browser/google_apis/base_operations.cc	View		4 chunks	+0 lines, -81 lines	0 comments	Download
M	chrome/browser/google_apis/mock_drive_service.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/google_apis/mock_drive_service.cc	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	chrome/browser/google_apis/operation_runner.h	View		3 chunks	+2 lines, -6 lines	0 comments	Download
M	chrome/browser/google_apis/operation_runner.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages