Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 11316240: mac: Build in C++11 mode. (Closed)

Created:
8 years ago by Nico
Modified:
8 years ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Visibility:
Public.

Description

mac: Build in C++11 mode. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170969

Patch Set 1 #

Patch Set 2 : comments #

Patch Set 3 : rebase #

Patch Set 4 : rebaes #

Total comments: 2

Patch Set 5 : tweak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -5 lines) Patch
M build/common.gypi View 1 2 3 4 1 chunk +26 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
Here it is. Looks like all dependencies are in by now. If this sticks, I'll ...
8 years ago (2012-12-03 23:55:55 UTC) #1
Mark Mentovai
Waiting on red trybots. https://codereview.chromium.org/11316240/diff/8001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/11316240/diff/8001/build/common.gypi#newcode3250 build/common.gypi:3250: # This warns on using ...
8 years ago (2012-12-04 03:52:08 UTC) #2
Nico
ShowInUninitializedTab fails on mac_asan on a whitespace CL too: https://codereview.chromium.org/11299325/ mac_rel just ran at too ...
8 years ago (2012-12-04 05:02:11 UTC) #3
Mark Mentovai
8 years ago (2012-12-04 05:04:44 UTC) #4
OK, LGTM (although consider adding the newlines, and maybe file a bug to track
-std=c++11.)

Powered by Google App Engine
This is Rietveld 408576698