Improve curtain mode error message.

remoting/webapp/client_screen.js

Index: remoting/webapp/client_screen.js
diff --git a/remoting/webapp/client_screen.js b/remoting/webapp/client_screen.js
index 3ffb0f848da96afc32a6cc9e1496cc5cb4a778a7..da8d82a26341ed006db9b2578757b3ed97142a98 100644
--- a/remoting/webapp/client_screen.js
+++ b/remoting/webapp/client_screen.js
@@ -255,10 +255,12 @@ function onClientStateChange_(oldState, newState) {
         remoting.setMode(remoting.AppMode.CLIENT_SESSION_FINISHED_ME2ME);
       }
     } else {
-      // The transition from CONNECTING to CLOSED state may happen
-      // only with older client plugins. Current version should go the
-      // FAILED state when connection fails.
-      showConnectError_(remoting.Error.INVALID_ACCESS_CODE);
+      // A state transition from CONNECTING -> CLOSED can happen if the host
+      // closes the connection without an error message instead of accepting it.
+      // For example, it does this if it fails to activate curtain mode. Since

[Sergey Ulanov, 2012/11/30 01:09:39]

Would it be better if the host was sending exact error code in this case instead
of just closing the connection? Or is the curtain failure is not frequent enough
to worry about it?

[Jamie, 2012/11/30 02:24:24]

That would definitely be an improvement, and I think we should do it in the
longer term. I couldn't see how to implement that without substantial surgery,
which I don't think this warrants right now.

+      // there's no way of knowing exactly what went wrong, we rely on server-
+      // side logs in this case and show a generic error message.
+      showConnectError_(remoting.Error.UNEXPECTED);
     }
 
   } else if (newState == remoting.ClientSession.State.FAILED) {