Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 1131623006: Use a response file for gn refs when running 'analyze' on gn bots. (Closed)

Created:
5 years, 7 months ago by Dirk Pranke
Modified:
5 years, 7 months ago
Reviewers:
brettw, scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use a response file for gn refs when running 'analyze' on gn bots. Previously we would invoke 'gn refs' once for each file modified in a CL; this was terribly inefficient. Switching to a response file makes things run much faster. This is a precursor to fixing the actual problem in bug 487035, because we will be doubling the number of times we need to call gn refs in the fix. R=scottmg@chromium.org BUG=487035 CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_rel;tryserver.chromium.win:win8_chromium_gn_rel Committed: https://crrev.com/f61de2f16ff7264dd9463d1978fb6acff598285f Cr-Commit-Position: refs/heads/master@{#329799}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix formatting nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -17 lines) Patch
M tools/mb/mb.py View 3 chunks +32 lines, -17 lines 0 comments Download
M tools/mb/mb_unittest.py View 1 2 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Dirk Pranke
See also https://codereview.chromium.org/1098603002 for the gn-side change that implemented the response files (landed a month ...
5 years, 7 months ago (2015-05-13 23:30:19 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131623006/1
5 years, 7 months ago (2015-05-13 23:41:22 UTC) #4
scottmg
lgtm https://codereview.chromium.org/1131623006/diff/1/tools/mb/mb_unittest.py File tools/mb/mb_unittest.py (right): https://codereview.chromium.org/1131623006/diff/1/tools/mb/mb_unittest.py#newcode67 tools/mb/mb_unittest.py:67: self.files[self.name] = self.buf wrong indent https://codereview.chromium.org/1131623006/diff/1/tools/mb/mb_unittest.py#newcode68 tools/mb/mb_unittest.py:68: nit; ...
5 years, 7 months ago (2015-05-13 23:57:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131623006/20001
5 years, 7 months ago (2015-05-14 00:13:00 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-14 04:10:02 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 04:10:48 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f61de2f16ff7264dd9463d1978fb6acff598285f
Cr-Commit-Position: refs/heads/master@{#329799}

Powered by Google App Engine
This is Rietveld 408576698