Issue 11316219: Improve debug printing of non-strict arguments object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11316219: Improve debug printing of non-strict arguments object. (Closed)

Created:
8 years ago by Michael Starzinger

Modified:
8 years ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Improve debug printing of non-strict arguments object. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=13079

Patch Set 1 #

Total comments: 1

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -3 lines)			Patch
	M	src/objects-printer.cc	View		2 chunks	+8 lines, -3 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

8 years ago (2012-11-28 13:20:54 UTC) #2

lgtm with nit

https://codereview.chromium.org/11316219/diff/1/src/objects-printer.cc
File src/objects-printer.cc (right):

https://codereview.chromium.org/11316219/diff/1/src/objects-printer.cc#newcod...
src/objects-printer.cc:398: PrintF(out, " %d:", i - 2);
Magic constants ftw. If there is a k-version of this, please use that.
Otherwise, ignore my comment ;)

Expand Messages | Collapse Messages