Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 11316218: Simplify and fix code aging. (Closed)

Created:
8 years ago by Sven Panne
Modified:
8 years ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Simplify and fix code aging. Making the code size predictable is hard, and to make things even more complicated, the start of a function can contain various stuff like calls to a profiling hook, receiver adjustment or dynamic frame alignment. Instead of tackling all these problems separately, we now simply record the offset where patching should happen later in the Code object itself. Committed: http://code.google.com/p/v8/source/detail?r=13081

Patch Set 1 #

Patch Set 2 : Simplified CompilationInfo constructor. #

Patch Set 3 : Rebased #

Total comments: 2

Patch Set 4 : Fixed comment and rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -202 lines) Patch
M src/arm/codegen-arm.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/arm/codegen-arm.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 2 chunks +1 line, -3 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/codegen.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler.h View 1 4 chunks +15 lines, -12 lines 0 comments Download
M src/compiler.cc View 1 1 chunk +31 lines, -35 lines 0 comments Download
M src/heap.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/codegen-ia32.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 1 chunk +0 lines, -36 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 3 chunks +1 line, -4 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 3 chunks +1 line, -9 lines 0 comments Download
M src/mips/codegen-mips.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/mips/codegen-mips.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 2 chunks +1 line, -3 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/objects.h View 1 2 3 3 chunks +8 lines, -2 lines 0 comments Download
M src/objects.cc View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/codegen-x64.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/x64/codegen-x64.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 3 chunks +1 line, -4 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
8 years ago (2012-11-28 14:05:34 UTC) #1
danno
lgtm with a nit! https://codereview.chromium.org/11316218/diff/4001/src/objects.h File src/objects.h (right): https://codereview.chromium.org/11316218/diff/4001/src/objects.h#newcode4328 src/objects.h:4328: // [prologue_offset]: Offset of the ...
8 years ago (2012-11-28 16:38:54 UTC) #2
Sven Panne
8 years ago (2012-11-29 07:38:17 UTC) #3
Message was sent while issue was closed.
Landing...

https://codereview.chromium.org/11316218/diff/4001/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/11316218/diff/4001/src/objects.h#newcode4328
src/objects.h:4328: // [prologue_offset]: Offset of the prologue, used for IC
aging.
On 2012/11/28 16:38:54, danno wrote:
> "IC" isn't correct, it's actually used for FUNCTIONs and OPTIMIZED_FUNCTIONs

Done.

Powered by Google App Engine
This is Rietveld 408576698