Implement TestRootCerts for Android

net/base/test_root_certs_android.cc

Index: net/base/test_root_certs_android.cc
diff --git a/net/base/test_root_certs_openssl.cc b/net/base/test_root_certs_android.cc
similarity index 54%
copy from net/base/test_root_certs_openssl.cc
copy to net/base/test_root_certs_android.cc
index e01d5c95dadc9f5e6879158c060ad346e83e41ac..21134ed1665a4fdb3ffe91a618f9b00d1224c09e 100644
--- a/net/base/test_root_certs_openssl.cc
+++ b/net/base/test_root_certs_android.cc
@@ -4,29 +4,19 @@
 
 #include "net/base/test_root_certs.h"
 
-#include <openssl/err.h>
-#include <openssl/x509v3.h>
-
 #include "base/location.h"
 #include "base/logging.h"
-#include "crypto/openssl_util.h"
+#include "net/android/network_library.h"
 #include "net/base/x509_certificate.h"
 
 namespace net {
 
 bool TestRootCerts::Add(X509Certificate* certificate) {
-  if (!X509_STORE_add_cert(X509Certificate::cert_store(),
-                           certificate->os_cert_handle())) {
-    unsigned long error_code = ERR_peek_error();
-    if (ERR_GET_LIB(error_code) != ERR_LIB_X509 ||
-        ERR_GET_REASON(error_code) != X509_R_CERT_ALREADY_IN_HASH_TABLE) {
-      crypto::ClearOpenSSLERRStack(FROM_HERE);
-      return false;
-    }
-    ERR_clear_error();
-  }
-
-  empty_ = false;
+  std::string cert_bytes;
+  X509Certificate::X509Certificate::GetDEREncoded(
+      certificate->os_cert_handle(), &cert_bytes);

[Ryan Sleevi, 2012/12/11 20:18:38]

BUG: Check return value here
BUG: You've redundantly used X509Certificate:: twice
STYLE: No need to use net:: prefix here (or line 27)

if (!X509Certificate::GetDEREncoded(certificate()->os_cert_handle(),
&cert_bytes))
  return false;
android::AddTestRootCertificate(...)

[ppi, 2012/12/11 20:57:04]

Thanks! Fixed in patch set 13.

+  net::android::AddTestRootCertificate(
+      reinterpret_cast<const uint8*>(cert_bytes.data()), cert_bytes.size());
   return true;
 }
 
@@ -34,7 +24,7 @@ void TestRootCerts::Clear() {
   if (empty_)
     return;
 
-  X509Certificate::ResetCertStore();
+  net::android::ClearTestRootCertificates();
   empty_ = true;
 }