net/base/test_root_certs.h - Issue 11316210: Implement TestRootCerts for Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/test_root_certs.h

Issue 11316210: Implement TestRootCerts for Android (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: remove an obsolete findbugs suppression Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/base/test_root_certs.h

diff --git a/net/base/test_root_certs.h b/net/base/test_root_certs.h

index 4d52dbcda5c088fd520785659413b42dfad1bbb3..a63fdb6e758d13dd1a5630f6e35139244da3b98c 100644

--- a/net/base/test_root_certs.h

+++ b/net/base/test_root_certs.h

@@ -91,7 +91,7 @@ class NET_EXPORT_PRIVATE TestRootCerts {

base::mac::ScopedCFTypeRef<CFMutableArrayRef> temporary_roots_;

#endif

-#if defined(OS_WIN) || defined(USE_OPENSSL)

+#if defined(OS_WIN) || defined(USE_OPENSSL) || defined(OS_ANDROID)

digit1 2012/11/30 10:05:25 nit: I don't think this is necessary, since USE_OP

Ryan Sleevi 2012/12/03 02:29:03 agreed

// True if there are no temporarily trusted root certificates.

bool empty_;

#endif