Implement TestRootCerts for Android

net/android/network_library.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_ANDROID_NETWORK_LIBRARY_H_
 #define NET_ANDROID_NETWORK_LIBRARY_H_
 
 #include <jni.h>
 
 #include <string>
@@ skipping 15 matching lines @@
   VERIFY_INVOCATION_ERROR,
 };
 
 // |cert_chain| is DER encoded chain of certificates, with the server's own
 // certificate listed first.
 // |auth_type| is as per the Java X509Certificate.checkServerTrusted method.
 
 VerifyResult VerifyX509CertChain(const std::vector<std::string>& cert_chain,
                                  const std::string& auth_type);
 
+// Adds a certificate as a root trust certificate to the trust manager.
+// |cert| is DER encoded certificate, |len| is its length in bytes.
+void AddLocalRootCertificate(const uint8* cert, size_t len);

[digit1, 2012/11/28 10:42:34]

I think it'd prefer if we called this AddTestRootCertificate() to make it clear
that this should only be used during testing. Same with
ClearLocalRootCertificates -> ClearTestRootCertificates.

[ppi, 2012/11/28 13:37:31]

Sure - done in patch set 2 (both in Java as well as C++ code).

On 2012/11/28 10:42:34, digit1 wrote:

+
+// Removes all root certificates added by |AddLocalRootCertificate| calls.
+void ClearLocalRootCertificates();
+
+
 // Helper for the <keygen> handler. Passes the DER-encoded key  pair via
 // JNI to the Credentials store. Note that the public key must be a DER
 // encoded SubjectPublicKeyInfo (X.509), as returned by i2d_PUBKEY()
 // (and *not* i2d_PublicKey(), which returns a PKCS#1 key).
 //
 // Also, the private key must be in PKCS#8 format, as returned by
 // i2d_PKCS8_PRIV_KEY_INFO(EVP_PKEY2PKCS8(pkey)), which is a different
 // format than what i2d_PrivateKey() returns, so don't use it either.
 //
 bool StoreKeyPair(const uint8* public_key,
@@ skipping 17 matching lines @@
 bool GetMimeTypeFromExtension(const std::string& extension,
                               std::string* result);
 
 // Register JNI methods
 NET_EXPORT bool RegisterNetworkLibrary(JNIEnv* env);
 
 }  // namespace android
 }  // namespace net
 
 #endif  // NET_ANDROID_NETWORK_LIBRARY_H_