Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 11316205: Remove setVersion plumbing from chromium (Closed)

Created:
8 years ago by dgrogan
Modified:
8 years ago
Reviewers:
Tom Sepez, jsbell
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, darin-cc_chromium.org, alecflett
Visibility:
Public.

Description

Remove setVersion plumbing from chromium BUG=161542 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=169857

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -122 lines) Patch
M content/browser/in_process_webkit/indexed_db_callbacks.h View 1 chunk +0 lines, -15 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_callbacks.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_dispatcher_host.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_dispatcher_host.cc View 2 chunks +0 lines, -21 lines 0 comments Download
M content/common/indexed_db/indexed_db_dispatcher.h View 2 chunks +0 lines, -9 lines 0 comments Download
M content/common/indexed_db/indexed_db_dispatcher.cc View 3 chunks +0 lines, -29 lines 0 comments Download
M content/common/indexed_db/indexed_db_messages.h View 2 chunks +0 lines, -12 lines 0 comments Download
M content/common/indexed_db/proxy_webidbdatabase_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/common/indexed_db/proxy_webidbdatabase_impl.cc View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
dgrogan
This can't be committed until webkit rolls past 135904.
8 years ago (2012-11-27 22:33:10 UTC) #1
dgrogan
Josh and Tom, could you review this?
8 years ago (2012-11-27 22:40:17 UTC) #2
Tom Sepez
Messages LGTM (deletion only).
8 years ago (2012-11-27 22:42:46 UTC) #3
jsbell
lgtm
8 years ago (2012-11-27 23:08:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgrogan@chromium.org/11316205/1
8 years ago (2012-11-28 01:02:10 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) aura_unit_tests, browser_tests, view_unittests
8 years ago (2012-11-28 02:25:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgrogan@chromium.org/11316205/1
8 years ago (2012-11-28 02:43:22 UTC) #7
commit-bot: I haz the power
8 years ago (2012-11-28 05:37:33 UTC) #8
Message was sent while issue was closed.
Change committed as 169857

Powered by Google App Engine
This is Rietveld 408576698