Always disable "content has shadow".

Always disable "content has shadow".

BUG=161603
TEST=as in bug


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169755

[Avi (use Gerrit), 2012-11-26 19:24:20]

I need to verify this on 10.6 and 10.7 but I believe this is the way to go.

[Nico, 2012-11-27 00:28:12]

https://codereview.chromium.org/11316172/diff/1002/ui/base/cocoa/underlay_ope...
File ui/base/cocoa/underlay_opengl_hosting_window.mm (right):

https://codereview.chromium.org/11316172/diff/1002/ui/base/cocoa/underlay_ope...
ui/base/cocoa/underlay_opengl_hosting_window.mm:117: [self
_setContentHasShadow:NO];
Hum, I would've expected this to force a regulare rectangular window shadow for
the bubbles, instead of a shadow that follows the bubble shape. But if it looks
good on 10.6-10.8, lgtm

[Avi (use Gerrit), 2012-11-27 14:51:52]

https://codereview.chromium.org/11316172/diff/1002/ui/base/cocoa/underlay_ope...
File ui/base/cocoa/underlay_opengl_hosting_window.mm (right):

https://codereview.chromium.org/11316172/diff/1002/ui/base/cocoa/underlay_ope...
ui/base/cocoa/underlay_opengl_hosting_window.mm:117: [self
_setContentHasShadow:NO];
That's the magic of "content has shadow = NO"; the shadow region is
scanline-by-scanline, first opaque pixel to last opaque pixel.

Or at least I hope so. I also need to verify on HiDPI too...

[Avi (use Gerrit), 2012-11-27 15:36:59]

Verified on 10.8, 10.7 HiDPI.

Attempting to run a binary built on my 10.8 machine on 10.6 fails with "child
SendMessage() failed: 0x44e". Gah. Googling that suggests that it's a build
issue.

[Avi (use Gerrit), 2012-11-27 18:39:47]

Verified on 10.6. Landing.

[commit-bot: I haz the power, 2012-11-27 18:40:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/11316172/1002

[commit-bot: I haz the power, 2012-11-27 21:18:09]

Change committed as 169755