chrome/common/extensions/manifest_unittest.cc - Issue 11316164: Implement ComplexFeature to support permission features with multiple rules.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_unittest.cc

Issue 11316164: Implement ComplexFeature to support permission features with multiple rules. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Renames and add TODO Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/extensions/manifest_unittest.cc

diff --git a/chrome/common/extensions/manifest_unittest.cc b/chrome/common/extensions/manifest_unittest.cc

index c0030b6bebbff2529c9c25b34ca8f4680253fc88..f0ddf73fa6fbf8d6e74f47e1aa50573005c4d155 100644

--- a/chrome/common/extensions/manifest_unittest.cc

+++ b/chrome/common/extensions/manifest_unittest.cc

@@ -13,6 +13,7 @@

#include "base/values.h"

#include "chrome/common/extensions/extension_manifest_constants.h"

#include "chrome/common/extensions/features/feature.h"

+#include "chrome/common/extensions/features/simple_feature.h"

#include "extensions/common/error_utils.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -94,7 +95,7 @@ TEST_F(ManifestTest, Extension) {

EXPECT_TRUE(error.empty());

ASSERT_EQ(2u, warnings.size());

{

- Feature feature;

+ SimpleFeature feature;

feature.set_name("background_page");

feature.set_max_manifest_version(1);

EXPECT_EQ(

« no previous file with comments | « chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc ('k') | no next file » | no next file with comments »