Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8303)

Unified Diff: chrome/common/extensions/features/simple_feature_provider.h

Issue 11316164: Implement ComplexFeature to support permission features with multiple rules. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Renames and add TODO Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/features/simple_feature_provider.h
diff --git a/chrome/common/extensions/features/simple_feature_provider.h b/chrome/common/extensions/features/simple_feature_provider.h
deleted file mode 100644
index 6da884e256e042694e3ae102c764f42a7464d4e8..0000000000000000000000000000000000000000
--- a/chrome/common/extensions/features/simple_feature_provider.h
+++ /dev/null
@@ -1,51 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef CHROME_COMMON_EXTENSIONS_FEATURES_SIMPLE_FEATURE_PROVIDER_H_
-#define CHROME_COMMON_EXTENSIONS_FEATURES_SIMPLE_FEATURE_PROVIDER_H_
-
-#include <set>
-#include <string>
-
-#include "base/memory/linked_ptr.h"
-#include "base/values.h"
-#include "chrome/common/extensions/features/feature.h"
-#include "chrome/common/extensions/features/feature_provider.h"
-
-namespace extensions {
-
-// Reads Features out of a simple JSON file description.
-class SimpleFeatureProvider : public FeatureProvider {
- public:
- typedef Feature*(*FeatureFactory)();
-
- // Creates a new SimpleFeatureProvider. Pass null to |factory| to have the
- // provider create plain old Feature instances.
- SimpleFeatureProvider(DictionaryValue* root, FeatureFactory factory);
- virtual ~SimpleFeatureProvider();
-
- // Gets an instance for the _manifest_features.json file that is baked into
- // Chrome as a resource.
- static SimpleFeatureProvider* GetManifestFeatures();
-
- // Gets an instance for the _permission_features.json file that is baked into
- // Chrome as a resource.
- static SimpleFeatureProvider* GetPermissionFeatures();
-
- // Returns all features described by this instance.
- std::set<std::string> GetAllFeatureNames() const;
-
- // Gets the feature |feature_name|, if it exists.
- virtual Feature* GetFeature(const std::string& feature_name) OVERRIDE;
-
- private:
- typedef std::map<std::string, linked_ptr<Feature> > FeatureMap;
- FeatureMap features_;
-
- FeatureFactory factory_;
-};
-
-} // namespace extensions
-
-#endif // CHROME_COMMON_EXTENSIONS_FEATURES_SIMPLE_FEATURE_PROVIDER_H_
« no previous file with comments | « chrome/common/extensions/features/simple_feature.cc ('k') | chrome/common/extensions/features/simple_feature_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698