chrome/common/extensions/features/simple_feature_provider.h - Issue 11316164: Implement ComplexFeature to support permission features with multiple rules.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/features/simple_feature_provider.h

Issue 11316164: Implement ComplexFeature to support permission features with multiple rules. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: comments Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/features/feature.h ('K') | « chrome/common/extensions/features/simple_feature.cc ('k') | chrome/common/extensions/features/simple_feature_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/features/simple_feature_provider.h

diff --git a/chrome/common/extensions/features/simple_feature_provider.h b/chrome/common/extensions/features/simple_feature_provider.h

index 6da884e256e042694e3ae102c764f42a7464d4e8..54648210dfdc6cd74c184ff97e9a160e41442fe5 100644

--- a/chrome/common/extensions/features/simple_feature_provider.h

+++ b/chrome/common/extensions/features/simple_feature_provider.h

@@ -5,24 +5,25 @@

#ifndef CHROME_COMMON_EXTENSIONS_FEATURES_SIMPLE_FEATURE_PROVIDER_H_

#define CHROME_COMMON_EXTENSIONS_FEATURES_SIMPLE_FEATURE_PROVIDER_H_

+#include <map>

#include <set>

#include <string>

#include "base/memory/linked_ptr.h"

#include "base/values.h"

-#include "chrome/common/extensions/features/feature.h"

#include "chrome/common/extensions/features/feature_provider.h"

+#include "chrome/common/extensions/features/simple_feature.h"

namespace extensions {

// Reads Features out of a simple JSON file description.

class SimpleFeatureProvider : public FeatureProvider {

public:

- typedef Feature*(*FeatureFactory)();

+ typedef SimpleFeature*(*FeatureFactory)();

// Creates a new SimpleFeatureProvider. Pass null to |factory| to have the

// provider create plain old Feature instances.

- SimpleFeatureProvider(DictionaryValue* root, FeatureFactory factory);

+ SimpleFeatureProvider(const DictionaryValue& root, FeatureFactory factory);

virtual ~SimpleFeatureProvider();

// Gets an instance for the _manifest_features.json file that is baked into