Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4947)

Unified Diff: chrome/common/extensions/api/extension_api_unittest.cc

Issue 11316164: Implement ComplexFeature to support permission features with multiple rules. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review comments, cleanup Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/extension_api_unittest.cc
diff --git a/chrome/common/extensions/api/extension_api_unittest.cc b/chrome/common/extensions/api/extension_api_unittest.cc
index 7d14560b4b636788d02043133d55064f6bc6eceb..786d1916899866e222dc7b1a42780a288167a572 100644
--- a/chrome/common/extensions/api/extension_api_unittest.cc
+++ b/chrome/common/extensions/api/extension_api_unittest.cc
@@ -16,6 +16,7 @@
#include "base/values.h"
#include "chrome/common/chrome_paths.h"
#include "chrome/common/extensions/extension.h"
+#include "chrome/common/extensions/features/simple_feature.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace extensions {
@@ -28,7 +29,7 @@ class TestFeatureProvider : public FeatureProvider {
}
virtual Feature* GetFeature(const std::string& name) OVERRIDE {
- Feature* result = new Feature();
+ SimpleFeature* result = new SimpleFeature();
result->set_name(name);
result->extension_types()->insert(Extension::TYPE_EXTENSION);
result->contexts()->insert(context_);
@@ -352,11 +353,13 @@ TEST(ExtensionAPI, GetAPINameFromFullName) {
TEST(ExtensionAPI, DefaultConfigurationFeatures) {
scoped_ptr<ExtensionAPI> api(ExtensionAPI::CreateWithDefaultConfiguration());
- Feature* bookmarks = api->GetFeature("bookmarks");
- Feature* bookmarks_create = api->GetFeature("bookmarks.create");
+ SimpleFeature* bookmarks =
+ static_cast<SimpleFeature*>(api->GetFeature("bookmarks"));
+ SimpleFeature* bookmarks_create =
+ static_cast<SimpleFeature*>(api->GetFeature("bookmarks.create"));
struct {
- Feature* feature;
+ SimpleFeature* feature;
// TODO(aa): More stuff to test over time.
} test_data[] = {
{ bookmarks },
@@ -364,7 +367,7 @@ TEST(ExtensionAPI, DefaultConfigurationFeatures) {
};
for (size_t i = 0; i < ARRAYSIZE_UNSAFE(test_data); ++i) {
- Feature* feature = test_data[i].feature;
+ SimpleFeature* feature = test_data[i].feature;
ASSERT_TRUE(feature) << i;
EXPECT_TRUE(feature->whitelist()->empty());

Powered by Google App Engine
This is Rietveld 408576698