chrome/common/extensions/features/simple_feature_provider_unittest.cc - Issue 11316164: Implement ComplexFeature to support permission features with multiple rules.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/features/simple_feature_provider_unittest.cc

Issue 11316164: Implement ComplexFeature to support permission features with multiple rules. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: new Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/features/simple_feature_provider.cc ('K') | « chrome/common/extensions/features/simple_feature_provider.cc ('k') | chrome/common/extensions/features/simple_feature_unittest.cc » ('j') | chrome/common/extensions/manifest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/features/simple_feature_provider_unittest.cc

diff --git a/chrome/common/extensions/features/simple_feature_provider_unittest.cc b/chrome/common/extensions/features/simple_feature_provider_unittest.cc

index 0503ddc7a30e99f406d50950145ec7b93d104a2d..bfa08efb56dd6b656194598768c29a47998d1039 100644

--- a/chrome/common/extensions/features/simple_feature_provider_unittest.cc

+++ b/chrome/common/extensions/features/simple_feature_provider_unittest.cc

@@ -8,12 +8,13 @@

using extensions::Extension;

using extensions::Feature;

+using extensions::SimpleFeature;

using extensions::SimpleFeatureProvider;

TEST(SimpleFeatureProvider, ManifestFeatures) {

SimpleFeatureProvider* provider =

SimpleFeatureProvider::GetManifestFeatures();

- Feature* feature = provider->GetFeature("description");

+ SimpleFeature* feature = provider->GetFeature("description");

ASSERT_TRUE(feature);

EXPECT_EQ(5u, feature->extension_types()->size());

EXPECT_EQ(1u, feature->extension_types()->count(Extension::TYPE_EXTENSION));

@@ -52,7 +53,7 @@ TEST(SimpleFeatureProvider, ManifestFeatures) {

TEST(SimpleFeatureProvider, PermissionFeatures) {

SimpleFeatureProvider* provider =

SimpleFeatureProvider::GetPermissionFeatures();

- Feature* feature = provider->GetFeature("contextMenus");

+ SimpleFeature* feature = provider->GetFeature("contextMenus");

ASSERT_TRUE(feature);

EXPECT_EQ(3u, feature->extension_types()->size());

EXPECT_EQ(1u, feature->extension_types()->count(Extension::TYPE_EXTENSION));