chrome/common/extensions/features/manifest_feature.h - Issue 11316164: Implement ComplexFeature to support permission features with multiple rules.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/features/manifest_feature.h

Issue 11316164: Implement ComplexFeature to support permission features with multiple rules. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: new Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/features/complex_feature_unittest.cc ('K') | « chrome/common/extensions/features/feature_unittest.cc ('k') | chrome/common/extensions/features/manifest_feature.cc » ('j') | chrome/common/extensions/features/permission_feature.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/features/manifest_feature.h

diff --git a/chrome/common/extensions/features/manifest_feature.h b/chrome/common/extensions/features/manifest_feature.h

index 0ec0cd72b742f698351bc6d799ba53701cc3949e..4d239694ee50ce24296e3cf3fc3bd2aeb8fed07a 100644

--- a/chrome/common/extensions/features/manifest_feature.h

+++ b/chrome/common/extensions/features/manifest_feature.h

@@ -5,11 +5,11 @@

#ifndef CHROME_COMMON_EXTENSIONS_FEATURES_MANIFEST_FEATURE_H_

#define CHROME_COMMON_EXTENSIONS_FEATURES_MANIFEST_FEATURE_H_

-#include "chrome/common/extensions/features/feature.h"

+#include "chrome/common/extensions/features/simple_feature.h"

namespace extensions {

-class ManifestFeature : public Feature {

+class ManifestFeature : public SimpleFeature {

not at google - send to devlin 2012/12/12 17:42:41 now that Feature is an interface, can we make this

justinlin 2012/12/14 12:26:26 Hmm.. not sure how you mean by this? I thought abo

not at google - send to devlin 2012/12/14 19:10:42 Something like this: https://codereview.chromium.o

public:

ManifestFeature();

virtual ~ManifestFeature();