Implement ComplexFeature to support permission features with multiple rules.

chrome/common/extensions/manifest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/manifest.h"
 
 #include "base/basictypes.h"
 #include "base/lazy_instance.h"
 #include "base/logging.h"
 #include "base/string_split.h"
 #include "base/stringprintf.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/common/extensions/extension_manifest_constants.h"
-#include "chrome/common/extensions/features/simple_feature_provider.h"
+#include "chrome/common/extensions/features/base_feature_provider.h"
 #include "extensions/common/error_utils.h"
 
 namespace errors = extension_manifest_errors;
 namespace keys = extension_manifest_keys;
 
 namespace extensions {
 
 Manifest::Manifest(Extension::Location location,
                    scoped_ptr<DictionaryValue> value)
     : location_(location),
@@ skipping 28 matching lines @@
     return;
   }
 
   // Check every feature to see if its in the manifest. Note that this means
   // we will ignore keys that are not features; we do this for forward
   // compatibility.
   // TODO(aa): Consider having an error here in the case of strict error
   // checking to let developers know when they screw up.
 
   std::set<std::string> feature_names =
-      SimpleFeatureProvider::GetManifestFeatures()->GetAllFeatureNames();
+      BaseFeatureProvider::GetManifestFeatures()->GetAllFeatureNames();
   for (std::set<std::string>::iterator feature_name = feature_names.begin();
        feature_name != feature_names.end(); ++feature_name) {
     // Use Get instead of HasKey because the former uses path expansion.
     if (!value_->Get(*feature_name, NULL))
       continue;
 
     Feature* feature =
-        SimpleFeatureProvider::GetManifestFeatures()->GetFeature(*feature_name);
+        BaseFeatureProvider::GetManifestFeatures()->GetFeature(*feature_name);
     Feature::Availability result = feature->IsAvailableToManifest(
         extension_id_, type_, Feature::ConvertLocation(location_),
         GetManifestVersion());
     if (!result.is_available())
       warnings->push_back(Extension::InstallWarning(
           Extension::InstallWarning::FORMAT_TEXT, result.message()));
   }
 
   // Also generate warnings for keys that are not features.
   for (DictionaryValue::key_iterator key = value_->begin_keys();
       key != value_->end_keys(); ++key) {
-    if (!SimpleFeatureProvider::GetManifestFeatures()->GetFeature(*key)) {
+    if (!BaseFeatureProvider::GetManifestFeatures()->GetFeature(*key)) {
       warnings->push_back(Extension::InstallWarning(
           Extension::InstallWarning::FORMAT_TEXT,
           base::StringPrintf("Unrecognized manifest key '%s'.",
                              (*key).c_str())));
     }
   }
 }
 
 bool Manifest::HasKey(const std::string& key) const {
   return CanAccessKey(key) && value_->HasKey(key);
@@ skipping 66 matching lines @@
     key += components[i];
     if (!CanAccessKey(key))
       return false;
     key += '.';
   }
   return true;
 }
 
 bool Manifest::CanAccessKey(const std::string& key) const {
   Feature* feature =
-      SimpleFeatureProvider::GetManifestFeatures()->GetFeature(key);
+      BaseFeatureProvider::GetManifestFeatures()->GetFeature(key);
   if (!feature)
     return true;
 
   return feature->IsAvailableToManifest(
       extension_id_, type_, Feature::ConvertLocation(location_),
       GetManifestVersion()).is_available();
 }
 
 }  // namespace extensions