Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: chrome/common/extensions/manifest.cc

Issue 11316164: Implement ComplexFeature to support permission features with multiple rules. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: new Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/manifest.h" 5 #include "chrome/common/extensions/manifest.h"
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/lazy_instance.h" 8 #include "base/lazy_instance.h"
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/string_split.h" 10 #include "base/string_split.h"
11 #include "base/stringprintf.h" 11 #include "base/stringprintf.h"
12 #include "base/utf_string_conversions.h" 12 #include "base/utf_string_conversions.h"
13 #include "chrome/common/extensions/extension_manifest_constants.h" 13 #include "chrome/common/extensions/extension_manifest_constants.h"
14 #include "chrome/common/extensions/features/complex_feature_provider.h"
not at google - send to devlin 2012/12/12 17:42:41 unused
justinlin 2012/12/14 12:26:26 Done.
14 #include "chrome/common/extensions/features/simple_feature_provider.h" 15 #include "chrome/common/extensions/features/simple_feature_provider.h"
15 #include "extensions/common/error_utils.h" 16 #include "extensions/common/error_utils.h"
16 17
17 namespace errors = extension_manifest_errors; 18 namespace errors = extension_manifest_errors;
18 namespace keys = extension_manifest_keys; 19 namespace keys = extension_manifest_keys;
19 20
20 namespace extensions { 21 namespace extensions {
21 22
22 Manifest::Manifest(Extension::Location location, 23 Manifest::Manifest(Extension::Location location,
23 scoped_ptr<DictionaryValue> value) 24 scoped_ptr<DictionaryValue> value)
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after
170 SimpleFeatureProvider::GetManifestFeatures()->GetFeature(key); 171 SimpleFeatureProvider::GetManifestFeatures()->GetFeature(key);
171 if (!feature) 172 if (!feature)
172 return true; 173 return true;
173 174
174 return feature->IsAvailableToManifest( 175 return feature->IsAvailableToManifest(
175 extension_id_, type_, Feature::ConvertLocation(location_), 176 extension_id_, type_, Feature::ConvertLocation(location_),
176 GetManifestVersion()).is_available(); 177 GetManifestVersion()).is_available();
177 } 178 }
178 179
179 } // namespace extensions 180 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698