Remove the last usages of PrefObserver outside of Prefs.

chrome/browser/prefs/mock_pref_change_callback.h

Index: chrome/browser/prefs/mock_pref_change_callback.h
diff --git a/chrome/browser/prefs/pref_observer_mock.h b/chrome/browser/prefs/mock_pref_change_callback.h
similarity index 65%
rename from chrome/browser/prefs/pref_observer_mock.h
rename to chrome/browser/prefs/mock_pref_change_callback.h
index be7f4ff455b54e0371e0f68c999de048d5f3cabb..a0ad10900eb0eb27b0b82c3804ba237a51f9a743 100644
--- a/chrome/browser/prefs/pref_observer_mock.h
+++ b/chrome/browser/prefs/mock_pref_change_callback.h
@@ -2,12 +2,12 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CHROME_BROWSER_PREFS_PREF_OBSERVER_MOCK_H_
-#define CHROME_BROWSER_PREFS_PREF_OBSERVER_MOCK_H_
+#ifndef CHROME_BROWSER_PREFS_MOCK_PREF_CHANGE_CALLBACK_H_
+#define CHROME_BROWSER_PREFS_MOCK_PREF_CHANGE_CALLBACK_H_
 
 #include <string>
 
-#include "base/prefs/public/pref_observer.h"
+#include "base/prefs/public/pref_change_registrar.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "testing/gmock/include/gmock/gmock.h"
 
@@ -33,16 +33,20 @@ MATCHER_P3(PrefValueMatches, prefs, pref_name, value, "") {
 }
 
 // A mock for testing preference notifications and easy setup of expectations.
-class PrefObserverMock : public PrefObserver {
+class MockPrefChangeCallback {
  public:
-  PrefObserverMock();
-  virtual ~PrefObserverMock();
+  MockPrefChangeCallback(PrefServiceBase* prefs);
+  virtual ~MockPrefChangeCallback();
 
-  MOCK_METHOD2(OnPreferenceChanged, void(PrefServiceBase*, const std::string&));
+  PrefChangeRegistrar::NamedChangeCallback GetCallback();
 
-  void Expect(PrefServiceBase* prefs,
-              const std::string& pref_name,
+  MOCK_METHOD1(OnPreferenceChanged, void(const std::string&));

[Mattias Nissler (ping if slow), 2012/12/04 10:10:34]

As mentioned elsewhere, you could put that declaration on the test fixture
classes that need this.

[Jói, 2012/12/04 10:55:57]

Leaving this as discussed elsewhere.

+
+  void Expect(const std::string& pref_name,
               const Value* value);
+
+ private:
+  PrefServiceBase* prefs_;
 };
 
-#endif  // CHROME_BROWSER_PREFS_PREF_OBSERVER_MOCK_H_
+#endif  // CHROME_BROWSER_PREFS_MOCK_PREF_CHANGE_CALLBACK_H_