Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Unified Diff: chrome/browser/prefs/mock_pref_change_callback.h

Issue 11316163: Remove the last usages of PrefObserver outside of Prefs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address review comments. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prefs/mock_pref_change_callback.h
diff --git a/chrome/browser/prefs/pref_observer_mock.h b/chrome/browser/prefs/mock_pref_change_callback.h
similarity index 64%
rename from chrome/browser/prefs/pref_observer_mock.h
rename to chrome/browser/prefs/mock_pref_change_callback.h
index be7f4ff455b54e0371e0f68c999de048d5f3cabb..34d9beb97d43542d00ce78e11a56362bd4d91c97 100644
--- a/chrome/browser/prefs/pref_observer_mock.h
+++ b/chrome/browser/prefs/mock_pref_change_callback.h
@@ -2,12 +2,12 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_BROWSER_PREFS_PREF_OBSERVER_MOCK_H_
-#define CHROME_BROWSER_PREFS_PREF_OBSERVER_MOCK_H_
+#ifndef CHROME_BROWSER_PREFS_MOCK_PREF_CHANGE_CALLBACK_H_
+#define CHROME_BROWSER_PREFS_MOCK_PREF_CHANGE_CALLBACK_H_
#include <string>
-#include "base/prefs/public/pref_observer.h"
+#include "base/prefs/public/pref_change_registrar.h"
#include "chrome/browser/prefs/pref_service.h"
#include "testing/gmock/include/gmock/gmock.h"
@@ -33,16 +33,20 @@ MATCHER_P3(PrefValueMatches, prefs, pref_name, value, "") {
}
// A mock for testing preference notifications and easy setup of expectations.
-class PrefObserverMock : public PrefObserver {
+class MockPrefChangeCallback {
public:
- PrefObserverMock();
- virtual ~PrefObserverMock();
+ explicit MockPrefChangeCallback(PrefServiceBase* prefs);
+ virtual ~MockPrefChangeCallback();
- MOCK_METHOD2(OnPreferenceChanged, void(PrefServiceBase*, const std::string&));
+ PrefChangeRegistrar::NamedChangeCallback GetCallback();
- void Expect(PrefServiceBase* prefs,
- const std::string& pref_name,
+ MOCK_METHOD1(OnPreferenceChanged, void(const std::string&));
+
+ void Expect(const std::string& pref_name,
const Value* value);
+
+ private:
+ PrefServiceBase* prefs_;
};
-#endif // CHROME_BROWSER_PREFS_PREF_OBSERVER_MOCK_H_
+#endif // CHROME_BROWSER_PREFS_MOCK_PREF_CHANGE_CALLBACK_H_
« no previous file with comments | « chrome/browser/plugins/plugin_status_pref_setter.cc ('k') | chrome/browser/prefs/mock_pref_change_callback.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698