chrome/browser/chromeos/input_method/browser_state_monitor_unittest.cc - Issue 11316163: Remove the last usages of PrefObserver outside of Prefs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/input_method/browser_state_monitor_unittest.cc

Issue 11316163: Remove the last usages of PrefObserver outside of Prefs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address review comments. Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chromeos/input_method/browser_state_monitor_unittest.cc

diff --git a/chrome/browser/chromeos/input_method/browser_state_monitor_unittest.cc b/chrome/browser/chromeos/input_method/browser_state_monitor_unittest.cc

index b73b05aa4bb8946e1392cf55956ce3a89767aa24..cebb82f8dccd1cc0f20caac6ae8569617edd4f9c 100644

--- a/chrome/browser/chromeos/input_method/browser_state_monitor_unittest.cc

+++ b/chrome/browser/chromeos/input_method/browser_state_monitor_unittest.cc

@@ -315,10 +315,10 @@ TEST(BrowserStateMonitorTest, TestUpdatePrefOnBrowserScreenDetails) {

monitor.SetPrefServiceForTesting(&prefs);

StringPrefMember previous;

- previous.Init(prefs::kLanguagePreviousInputMethod, &prefs, NULL);

+ previous.Init(prefs::kLanguagePreviousInputMethod, &prefs);

EXPECT_EQ("", previous.GetValue());

StringPrefMember current;

- current.Init(prefs::kLanguageCurrentInputMethod, &prefs, NULL);

+ current.Init(prefs::kLanguageCurrentInputMethod, &prefs);

EXPECT_EQ("", current.GetValue());

monitor.Observe(chrome::NOTIFICATION_LOGIN_USER_CHANGED,

« no previous file with comments | « chrome/browser/autofill/autocomplete_history_manager.cc ('k') | chrome/browser/chromeos/login/login_utils.cc » ('j') | no next file with comments »