Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: chrome/browser/ui/webui/options/core_options_handler.cc

Issue 11316163: Remove the last usages of PrefObserver outside of Prefs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix build. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/core_options_handler.cc
diff --git a/chrome/browser/ui/webui/options/core_options_handler.cc b/chrome/browser/ui/webui/options/core_options_handler.cc
index 3a07265d5fd7b5e633c366e0b0bf729267373211..44cd7fca188f08f99b69390cfbd42028e57b6543 100644
--- a/chrome/browser/ui/webui/options/core_options_handler.cc
+++ b/chrome/browser/ui/webui/options/core_options_handler.cc
@@ -57,7 +57,13 @@ CoreOptionsHandler::CoreOptionsHandler()
CoreOptionsHandler::~CoreOptionsHandler() {}
void CoreOptionsHandler::InitializeHandler() {
- plugin_status_pref_setter_.Init(Profile::FromWebUI(web_ui()), this);
+ Profile* profile = Profile::FromWebUI(web_ui());
+
+ plugin_status_pref_setter_.Init(
+ profile,
+ base::Bind(&CoreOptionsHandler::OnPreferenceChanged,
+ base::Unretained(this),
+ profile->GetPrefs()));
pref_change_filters_[prefs::kMetricsReportingEnabled] =
base::Bind(&AllowMetricsReportingChange);
@@ -200,10 +206,19 @@ base::Value* CoreOptionsHandler::FetchPref(const std::string& pref_name) {
}
void CoreOptionsHandler::ObservePref(const std::string& pref_name) {
- if (g_browser_process->local_state()->FindPreference(pref_name.c_str()))
- local_state_registrar_.Add(pref_name.c_str(), this);
- else
- registrar_.Add(pref_name.c_str(), this);
+ if (g_browser_process->local_state()->FindPreference(pref_name.c_str())) {
+ local_state_registrar_.Add(
+ pref_name.c_str(),
+ base::Bind(&CoreOptionsHandler::OnPreferenceChanged,
+ base::Unretained(this),
+ local_state_registrar_.prefs()));
+ } else {
+ registrar_.Add(
+ pref_name.c_str(),
+ base::Bind(&CoreOptionsHandler::OnPreferenceChanged,
+ base::Unretained(this),
+ registrar_.prefs()));
+ }
}
void CoreOptionsHandler::StopObservingPref(const std::string& pref_name) {

Powered by Google App Engine
This is Rietveld 408576698