Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1318)

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_action_context_menu.mm

Issue 11316163: Remove the last usages of PrefObserver outside of Prefs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix build. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/extensions/extension_action_context_menu.mm
diff --git a/chrome/browser/ui/cocoa/extensions/extension_action_context_menu.mm b/chrome/browser/ui/cocoa/extensions/extension_action_context_menu.mm
index 5ed0ad8459f9fa8104315dc6e92e8fb2df38479c..f2701f81773eca6a4c63041e435cbd807ee5940b 100644
--- a/chrome/browser/ui/cocoa/extensions/extension_action_context_menu.mm
+++ b/chrome/browser/ui/cocoa/extensions/extension_action_context_menu.mm
@@ -89,18 +89,20 @@ class AsyncUninstaller : public ExtensionUninstallDialog::Delegate {
namespace extension_action_context_menu {
-class DevmodeObserver : public PrefObserver {
+class DevmodeObserver {
public:
DevmodeObserver(ExtensionActionContextMenu* menu,
PrefService* service)
: menu_(menu), pref_service_(service) {
registrar_.Init(pref_service_);
- registrar_.Add(prefs::kExtensionsUIDeveloperMode, this);
+ registrar_.Add(
+ prefs::kExtensionsUIDeveloperMode,
+ base::Bind(&DevmodeObserver::OnExtensionsUIDeveloperModeChanged,
+ base::Unretained(this)));
}
virtual ~DevmodeObserver() {}
- void OnPreferenceChanged(PrefServiceBase* service,
- const std::string& pref_name) {
+ void OnExtensionsUIDeveloperModeChanged() {
[menu_ updateInspectorItem];
}

Powered by Google App Engine
This is Rietveld 408576698