Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Side by Side Diff: chrome/browser/plugins/plugin_status_pref_setter.cc

Issue 11316163: Remove the last usages of PrefObserver outside of Prefs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address review comments. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/plugins/plugin_status_pref_setter.h" 5 #include "chrome/browser/plugins/plugin_status_pref_setter.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "chrome/browser/pepper_flash_settings_manager.h" 8 #include "chrome/browser/pepper_flash_settings_manager.h"
9 #include "chrome/browser/plugins/plugin_data_remover_helper.h" 9 #include "chrome/browser/plugins/plugin_data_remover_helper.h"
10 #include "chrome/browser/plugins/plugin_prefs.h" 10 #include "chrome/browser/plugins/plugin_prefs.h"
11 #include "chrome/browser/prefs/pref_service.h" 11 #include "chrome/browser/prefs/pref_service.h"
12 #include "chrome/browser/profiles/profile.h" 12 #include "chrome/browser/profiles/profile.h"
13 #include "chrome/common/chrome_notification_types.h" 13 #include "chrome/common/chrome_notification_types.h"
14 #include "chrome/common/pref_names.h" 14 #include "chrome/common/pref_names.h"
15 #include "content/public/browser/browser_thread.h" 15 #include "content/public/browser/browser_thread.h"
16 #include "content/public/browser/notification_source.h" 16 #include "content/public/browser/notification_source.h"
17 #include "content/public/browser/plugin_service.h" 17 #include "content/public/browser/plugin_service.h"
18 #include "webkit/plugins/webplugininfo.h" 18 #include "webkit/plugins/webplugininfo.h"
19 19
20 using content::BrowserThread; 20 using content::BrowserThread;
21 using content::PluginService; 21 using content::PluginService;
22 22
23 PluginStatusPrefSetter::PluginStatusPrefSetter() 23 PluginStatusPrefSetter::PluginStatusPrefSetter()
24 : profile_(NULL), 24 : profile_(NULL),
25 ALLOW_THIS_IN_INITIALIZER_LIST(factory_(this)) {} 25 ALLOW_THIS_IN_INITIALIZER_LIST(factory_(this)) {}
26 26
27 PluginStatusPrefSetter::~PluginStatusPrefSetter() { 27 PluginStatusPrefSetter::~PluginStatusPrefSetter() {
28 } 28 }
29 29
30 void PluginStatusPrefSetter::Init(Profile* profile, 30 void PluginStatusPrefSetter::Init(
31 PrefObserver* observer) { 31 Profile* profile,
32 const BooleanPrefMember::NamedChangeCallback& observer) {
32 clear_plugin_lso_data_enabled_.Init(prefs::kClearPluginLSODataEnabled, 33 clear_plugin_lso_data_enabled_.Init(prefs::kClearPluginLSODataEnabled,
33 profile->GetPrefs(), observer); 34 profile->GetPrefs(), observer);
34 pepper_flash_settings_enabled_.Init(prefs::kPepperFlashSettingsEnabled, 35 pepper_flash_settings_enabled_.Init(prefs::kPepperFlashSettingsEnabled,
35 profile->GetPrefs(), observer); 36 profile->GetPrefs(), observer);
36 profile_ = profile; 37 profile_ = profile;
37 registrar_.Add(this, chrome::NOTIFICATION_PLUGIN_ENABLE_STATUS_CHANGED, 38 registrar_.Add(this, chrome::NOTIFICATION_PLUGIN_ENABLE_STATUS_CHANGED,
38 content::Source<Profile>(profile)); 39 content::Source<Profile>(profile));
39 StartUpdate(); 40 StartUpdate();
40 } 41 }
41 42
(...skipping 20 matching lines...) Expand all
62 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 63 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
63 // Set the values on the PrefService instead of through the PrefMembers to 64 // Set the values on the PrefService instead of through the PrefMembers to
64 // notify observers if they changed. 65 // notify observers if they changed.
65 profile_->GetPrefs()->SetBoolean( 66 profile_->GetPrefs()->SetBoolean(
66 clear_plugin_lso_data_enabled_.GetPrefName().c_str(), 67 clear_plugin_lso_data_enabled_.GetPrefName().c_str(),
67 PluginDataRemoverHelper::IsSupported(plugin_prefs)); 68 PluginDataRemoverHelper::IsSupported(plugin_prefs));
68 profile_->GetPrefs()->SetBoolean( 69 profile_->GetPrefs()->SetBoolean(
69 pepper_flash_settings_enabled_.GetPrefName().c_str(), 70 pepper_flash_settings_enabled_.GetPrefName().c_str(),
70 PepperFlashSettingsManager::IsPepperFlashInUse(plugin_prefs, NULL)); 71 PepperFlashSettingsManager::IsPepperFlashInUse(plugin_prefs, NULL));
71 } 72 }
OLDNEW
« no previous file with comments | « chrome/browser/plugins/plugin_status_pref_setter.h ('k') | chrome/browser/prefs/mock_pref_change_callback.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698