Remove the last usages of PrefObserver outside of Prefs.

chrome/browser/ui/webui/options/core_options_handler.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_WEBUI_OPTIONS_CORE_OPTIONS_HANDLER_H_
 #define CHROME_BROWSER_UI_WEBUI_OPTIONS_CORE_OPTIONS_HANDLER_H_
 
 #include <map>
 #include <string>
 
 #include "base/callback.h"
 #include "base/prefs/public/pref_change_registrar.h"
-#include "base/prefs/public/pref_observer.h"
 #include "base/values.h"
 #include "chrome/browser/plugins/plugin_status_pref_setter.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/ui/webui/options/options_ui.h"
 
 namespace options {
 
 // Core options UI handler.
 // Handles resource and JS calls common to all options sub-pages.
-class CoreOptionsHandler : public OptionsPageUIHandler,
-                           public PrefObserver {
+class CoreOptionsHandler : public OptionsPageUIHandler {
  public:
   CoreOptionsHandler();
   virtual ~CoreOptionsHandler();
 
   // OptionsPageUIHandler implementation.
   virtual void GetLocalizedValues(DictionaryValue* localized_strings) OVERRIDE;
   virtual void InitializeHandler() OVERRIDE;
   virtual void InitializePage() OVERRIDE;
   virtual void Uninitialize() OVERRIDE;
 
-  // PrefObserver implementation.
-  virtual void OnPreferenceChanged(PrefServiceBase* service,
-                                   const std::string& pref_name) OVERRIDE;
-
   // WebUIMessageHandler implementation.
   virtual void RegisterMessages() OVERRIDE;
 
   void set_handlers_host(OptionsPageUIHandlerHost* handlers_host) {
     handlers_host_ = handlers_host;
   }
 
   // Adds localized strings to |localized_strings|.
   static void GetStaticLocalizedValues(
       base::DictionaryValue* localized_strings);
@@ skipping 14 matching lines @@
                        const base::Value* value,
                        const std::string& metric);
 
   // Clears pref value for given |pref_name|.
   void ClearPref(const std::string& pref_name, const std::string& metric);
 
   // Records a user metric action for the given value.
   void ProcessUserMetric(const base::Value* value,
                          const std::string& metric);
 
+  // We need to use virtual dispatch as handling of some prefs may be
+  // finessed in subclasses.  We need to include the PrefServiceBase
+  // pointer so that subclasses can know whether we are observing the
+  // pref from the local state or not.

[Mattias Nissler (ping if slow), 2012/12/04 10:47:12]

Some people feel strongly about avoiding use of pronouns in comments ;) I think
it's fine, up to you.

[Jói, 2012/12/04 10:55:57]

The rest of the comments in this file seem to avoid pronouns so I've updated
this to match.

+  virtual void OnPreferenceChanged(PrefServiceBase* service,
+                                   const std::string& pref_name);
+
   // Notifies registered JS callbacks on change in |pref_name| preference.
   // |controlling_pref_name| controls if |pref_name| is managed by
   // policy/extension; empty |controlling_pref_name| indicates no other pref is
   // controlling |pref_name|.
   void NotifyPrefChanged(const std::string& pref_name,
                          const std::string& controlling_pref_name);
 
   // Calls JS callbacks to report a change in the value of the |name|
   // preference. |value| is the new value for |name|.  Called from
   // Notify*Changed methods to fire off the notifications.
@@ skipping 83 matching lines @@
   typedef std::map<std::string, base::Callback<bool(const base::Value*)> >
       PrefChangeFilterMap;
   PrefChangeFilterMap pref_change_filters_;
 
   DISALLOW_COPY_AND_ASSIGN(CoreOptionsHandler);
 };
 
 }  // namespace options
 
 #endif  // CHROME_BROWSER_UI_WEBUI_OPTIONS_CORE_OPTIONS_HANDLER_H_