Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11316161: Refactor BrowserFont to new design (Closed)

Created:
8 years ago by victorhsieh
Modified:
8 years ago
Reviewers:
brettw
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Refactor BrowserFont to new design TEST=browser_tests,ppapi/example/font BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169611

Patch Set 1 : #

Total comments: 6

Patch Set 2 : #

Patch Set 3 : dep #

Patch Set 4 : dep #

Patch Set 5 : dep2 #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -601 lines) Patch
M content/renderer/pepper/pepper_in_process_resource_creation.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/pepper/pepper_in_process_resource_creation.cc View 1 2 chunks +16 lines, -0 lines 0 comments Download
M ppapi/ppapi_internal.gyp View 1 2 3 4 5 2 chunks +6 lines, -0 lines 0 comments Download
M ppapi/ppapi_proxy.gypi View 2 chunks +3 lines, -0 lines 0 comments Download
M ppapi/ppapi_shared.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
A + ppapi/proxy/browser_font_resource_trusted.h View 5 chunks +19 lines, -22 lines 0 comments Download
A + ppapi/proxy/browser_font_resource_trusted.cc View 1 11 chunks +19 lines, -30 lines 0 comments Download
M ppapi/proxy/resource_creation_proxy.cc View 1 3 chunks +5 lines, -3 lines 0 comments Download
D ppapi/shared_impl/private/ppb_browser_font_trusted_shared.h View 1 chunk +0 lines, -88 lines 0 comments Download
D ppapi/shared_impl/private/ppb_browser_font_trusted_shared.cc View 1 chunk +0 lines, -440 lines 0 comments Download
M webkit/plugins/ppapi/resource_creation_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M webkit/plugins/ppapi/resource_creation_impl.cc View 2 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
victorhsieh
8 years ago (2012-11-26 09:35:49 UTC) #1
brettw
lgtm https://codereview.chromium.org/11316161/diff/4001/content/renderer/pepper/pepper_in_process_resource_creation.cc File content/renderer/pepper/pepper_in_process_resource_creation.cc (right): https://codereview.chromium.org/11316161/diff/4001/content/renderer/pepper/pepper_in_process_resource_creation.cc#newcode57 content/renderer/pepper/pepper_in_process_resource_creation.cc:57: if (!ppapi::proxy::BrowserFontResource_Trusted::IsPPFontDescriptionValid( Can you do this at the ...
8 years ago (2012-11-26 23:50:37 UTC) #2
victorhsieh
https://codereview.chromium.org/11316161/diff/4001/content/renderer/pepper/pepper_in_process_resource_creation.cc File content/renderer/pepper/pepper_in_process_resource_creation.cc (right): https://codereview.chromium.org/11316161/diff/4001/content/renderer/pepper/pepper_in_process_resource_creation.cc#newcode57 content/renderer/pepper/pepper_in_process_resource_creation.cc:57: if (!ppapi::proxy::BrowserFontResource_Trusted::IsPPFontDescriptionValid( On 2012/11/26 23:50:37, brettw wrote: > Can ...
8 years ago (2012-11-27 03:00:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/victorhsieh@chromium.org/11316161/7002
8 years ago (2012-11-27 03:01:43 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
8 years ago (2012-11-27 03:37:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/victorhsieh@chromium.org/11316161/2003
8 years ago (2012-11-27 03:55:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/victorhsieh@chromium.org/11316161/6003
8 years ago (2012-11-27 04:31:23 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
8 years ago (2012-11-27 05:05:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/victorhsieh@chromium.org/11316161/10006
8 years ago (2012-11-27 05:44:39 UTC) #9
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
8 years ago (2012-11-27 06:25:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/victorhsieh@chromium.org/11316161/5017
8 years ago (2012-11-27 06:42:19 UTC) #11
commit-bot: I haz the power
8 years ago (2012-11-27 08:39:32 UTC) #12
Message was sent while issue was closed. 
Change committed as 169611

Powered by Google App Engine
This is Rietveld 408576698