content/components/web_contents_delegate_android/web_contents_delegate_android.h - Issue 11316153: implement input type=color for android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/components/web_contents_delegate_android/web_contents_delegate_android.h

Issue 11316153: implement input type=color for android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix a FindBug error Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/components/web_contents_delegate_android/color_chooser_android.cc ('K') | « content/components/web_contents_delegate_android/java/src/org/chromium/content/components/web_contents_delegate_android/ColorChooserAndroid.java ('k') | content/components/web_contents_delegate_android/web_contents_delegate_android.cc » ('j') | ui/android/java/src/org/chromium/ui/ColorPickerDialog.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/components/web_contents_delegate_android/web_contents_delegate_android.h

diff --git a/content/components/web_contents_delegate_android/web_contents_delegate_android.h b/content/components/web_contents_delegate_android/web_contents_delegate_android.h

index 967177cc94e71db1d8fecbac6c79810753d2a9fc..2cc126377a36a4ac0a274b1aa1742648c7fa6403 100644

--- a/content/components/web_contents_delegate_android/web_contents_delegate_android.h

+++ b/content/components/web_contents_delegate_android/web_contents_delegate_android.h

@@ -55,6 +55,9 @@ class WebContentsDelegateAndroid : public WebContentsDelegate {

WebContents* source,

const OpenURLParams& params) OVERRIDE;

+ virtual content::ColorChooser* OpenColorChooser(

+ content::WebContents* web_contents, int color_chooser_id,

bulach 2012/11/26 11:29:32 nit: from the methods around here, "content::WebCo

Miguel Garcia 2012/11/26 13:25:58 In the .cc file sometimes is web_contents sometime

+ SkColor color) OVERRIDE;

virtual void NavigationStateChanged(const WebContents* source,

unsigned changed_flags) OVERRIDE;

virtual void AddNewContents(WebContents* source,