Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1131613002: use floor for mip-level choice (Closed)

Created:
5 years, 7 months ago by reed1
Modified:
5 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

use floor for mip-level choice this chrome change must land first: https://codereview.chromium.org/1131663002/ BUG=skia: Committed: https://skia.googlesource.com/skia/+/c1e1faae076a26e0706146e490a60d2894835cd5

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M src/core/SkMipMap.cpp View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131613002/1
5 years, 7 months ago (2015-05-06 15:40:15 UTC) #2
reed1
5 years, 7 months ago (2015-05-06 15:40:17 UTC) #4
robertphillips
lgtm
5 years, 7 months ago (2015-05-06 15:45:02 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-06 15:48:01 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131613002/20001
5 years, 7 months ago (2015-05-06 18:16:11 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-06 18:22:11 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131613002/20001
5 years, 7 months ago (2015-05-06 20:02:14 UTC) #14
commit-bot: I haz the power
5 years, 7 months ago (2015-05-06 20:02:44 UTC) #15
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/c1e1faae076a26e0706146e490a60d2894835cd5

Powered by Google App Engine
This is Rietveld 408576698