Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Unified Diff: sdk/lib/_internal/compiler/implementation/compiler.dart

Issue 11316113: Creating a common library for all DOM types. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Review feedback. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/native_handler.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/compiler.dart
diff --git a/sdk/lib/_internal/compiler/implementation/compiler.dart b/sdk/lib/_internal/compiler/implementation/compiler.dart
index e770cff2319056437c6eff12c693a9ed17a56240..c78ef4c85de2075a82d175e6c502a215ac4afffb 100644
--- a/sdk/lib/_internal/compiler/implementation/compiler.dart
+++ b/sdk/lib/_internal/compiler/implementation/compiler.dart
@@ -487,13 +487,16 @@ abstract class Compiler implements DiagnosticListener {
void maybeEnableJSHelper(LibraryElement library) {
String libraryName = library.uri.toString();
if (library.entryCompilationUnit.script.name.contains(
- 'dart/tests/compiler/dart2js_native')
- || libraryName == 'dart:mirrors'
ahe 2012/11/27 07:57:05 Why are you changing the style here?
blois 2012/11/27 17:18:08 Per previous feedback on this CL, the style guide
sra1 2012/11/27 21:46:54 Pete *is* following the existing style at line 610
- || libraryName == 'dart:isolate'
- || libraryName == 'dart:math'
- || libraryName == 'dart:html'
- || libraryName == 'dart:svg') {
- if (libraryName == 'dart:html' || libraryName == 'dart:mirrors') {
+ 'dart/tests/compiler/dart2js_native') ||
+ libraryName == 'dart:html_common' ||
+ libraryName == 'dart:mirrors' ||
+ libraryName == 'dart:isolate' ||
+ libraryName == 'dart:math' ||
+ libraryName == 'dart:html' ||
+ libraryName == 'dart:svg') {
+ if (libraryName == 'dart:html' ||
+ libraryName == 'dart:mirrors' ||
+ libraryName == 'dart:html_common') {
// dart:html needs access to convertDartClosureToJS.
// dart:mirrors needs access to the Primitives class.
importHelperLibrary(library);
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/native_handler.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698