Creating a common library for all DOM types.

sdk/lib/_internal/compiler/implementation/compiler.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart2js;
 
 /**
  * If true, print a warning for each method that was resolved, but not
  * compiled.
  */
@@ skipping 472 matching lines @@
     library.addToScope(new ForeignElement(
         const SourceString('DART_CLOSURE_TO_JS'), library), this);
   }
 
   // TODO(karlklose,floitsch): move this to the javascript backend.
   /** Enable the 'JS' helper for a library if needed. */
   void maybeEnableJSHelper(LibraryElement library) {
     String libraryName = library.uri.toString();
     if (library.entryCompilationUnit.script.name.contains(
             'dart/tests/compiler/dart2js_native')
+        || libraryName == 'dart:html_common'
         || libraryName == 'dart:mirrors'
         || libraryName == 'dart:isolate'
         || libraryName == 'dart:math'
         || libraryName == 'dart:html'
         || libraryName == 'dart:svg') {
-      if (libraryName == 'dart:html' || libraryName == 'dart:mirrors') {
+      if (libraryName == 'dart:html'
+          || libraryName == 'dart:mirrors'
+          || libraryName == 'dart:html_common') {

[sra1, 2012/11/21 05:54:33]

Coding style is to put || at the end of the previous line.

http://www.dartlang.org/articles/style-guide/#do-place-the-operator-on-the-pr...

[blois, 2012/11/26 18:10:34]

Done.

         // dart:html needs access to convertDartClosureToJS.
         // dart:mirrors needs access to the Primitives class.
         importHelperLibrary(library);
       }
       library.addToScope(findHelper(const SourceString('JS')), this);
       Element jsIndexingBehaviorInterface =
           findHelper(const SourceString('JavaScriptIndexingBehavior'));
       if (jsIndexingBehaviorInterface != null) {
         library.addToScope(jsIndexingBehaviorInterface, this);
       }
@@ skipping 431 matching lines @@
   // TODO(johnniwinther): Use [spannable] and [message] to provide better
   // information on assertion errors.
   if (condition is Function){
     condition = condition();
   }
   if (spannable == null || !condition) {
     throw new SpannableAssertionFailure(spannable, message);
   }
   return true;
 }