src/runtime.cc - Issue 11316104: Missing check for exception.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime.cc

Issue 11316104: Missing check for exception. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime.cc

diff --git a/src/runtime.cc b/src/runtime.cc

index 838681f589140db6af40c61a5274c417f07c9530..252b624024cd431bed30f75165798abfa7108b62 100644

--- a/src/runtime.cc

+++ b/src/runtime.cc

@@ -1109,6 +1109,7 @@ static MaybeObject* GetOwnProperty(Isolate* isolate,

elms->set(WRITABLE_INDEX, heap->ToBoolean((attrs & READ_ONLY) == 0));

// GetProperty does access check.

Handle<Object> value = GetProperty(obj, name);

+ if (value.is_null()) return Failure::Exception();

elms->set(VALUE_INDEX, *value);

} else {

// Access checks are performed for both accessors separately.

« no previous file with comments | « no previous file | no next file » | no next file with comments »