webkit/plugins/npapi/plugin_list_win.cc - Issue 11316101: Merge 167979 - Remove PluginList::RemovePlugin() and directly remove old plug-ins from plug-in list…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/plugins/npapi/plugin_list_win.cc

Issue 11316101: Merge 167979 - Remove PluginList::RemovePlugin() and directly remove old plug-ins from plug-in list… (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1312/src/

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webkit/plugins/npapi/plugin_list_win.cc

===================================================================

--- webkit/plugins/npapi/plugin_list_win.cc (revision 168780)

+++ webkit/plugins/npapi/plugin_list_win.cc (working copy)

@@ -348,7 +348,7 @@

(plugin1 == kJavaDeploy2 && plugin2 == kJavaDeploy1)) {

if (!IsNewerVersion((*plugins)[j].version, info.version))

return false; // We have loaded a plugin whose version is newer.

- PluginList::RemovePlugin((*plugins)[j].path, plugins);

+ plugins->erase(plugins->begin() + j);

break;

}

@@ -398,7 +398,7 @@

for (size_t j = 0; j < plugins->size(); ++j) {

if ((*plugins)[j].path.BaseName().value() == kOldWMPPlugin) {

- PluginList::RemovePlugin((*plugins)[j].path, plugins);

+ plugins->erase(plugins->begin() + j);

break;

}

« no previous file with comments | « webkit/plugins/npapi/plugin_list.cc ('k') | no next file » | no next file with comments »