tools/testing/dart/test_suite.dart - Issue 11316100: Make SummaryReport.addCompileErrorSkipTest() depend on --report

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/testing/dart/test_suite.dart

Issue 11316100: Make SummaryReport.addCompileErrorSkipTest() depend on --report (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/testing/dart/test_suite.dart

diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart

index 3705e577991ca853808f3faee5b4b6ad1d58cfc2..a26f877688d0a9781ced2add111cfe913006a66c 100644

--- a/tools/testing/dart/test_suite.dart

+++ b/tools/testing/dart/test_suite.dart

@@ -615,7 +615,8 @@ class StandardTestSuite extends TestSuite {

Set<String> expectations = testExpectations.expectations(testName);

if (info.hasCompileError &&

- TestUtils.isBrowserRuntime(configuration['runtime'])) {

+ TestUtils.isBrowserRuntime(configuration['runtime']) &&

+ configuration['report']) {

SummaryReport.addCompileErrorSkipTest();

return;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »