google_apis: Rename and simplify GenerateGetDocumentsURL()

google_apis: Rename and simplify GenerateGetDocumentsURL()

Rename GenerateGetDocumentsURL() to GenerateDocumentListUrl(), and
simplify the code per hashimoto's suggestion.

Thanks to the unit test added in the previous patch, we were able to
simplify the code safely. :)

BUG=161718
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=168747

[satorux1, 2012-11-20 05:26:06]

Your suggestion was great!

[satorux1, 2012-11-20 05:57:42]

Please put this on hold. I'm making a bit more cleanup

[hashimoto, 2012-11-20 05:58:40]

lgtm

[hashimoto, 2012-11-20 05:59:35]

On 2012/11/20 05:58:40, hashimoto wrote:
> lgtm

oops, please forget this comment.

[satorux1, 2012-11-20 06:04:27]

done. please take another look

[hashimoto, 2012-11-20 06:07:35]

looks better, thanks

https://codereview.chromium.org/11316097/diff/7002/chrome/browser/google_apis...
File chrome/browser/google_apis/gdata_wapi_url_util.cc (right):

https://codereview.chromium.org/11316097/diff/7002/chrome/browser/google_apis...
chrome/browser/google_apis/gdata_wapi_url_util.cc:108: if
(directory_resource_id.empty()) {
How about putting start_changestamp > 0 case before start_changestamp == 0 case?
This way, we can reduce the indent level of if (directory_resource_id.empty()).

[satorux1, 2012-11-20 06:13:28]

http://codereview.chromium.org/11316097/diff/7002/chrome/browser/google_apis/...
File chrome/browser/google_apis/gdata_wapi_url_util.cc (right):

http://codereview.chromium.org/11316097/diff/7002/chrome/browser/google_apis/...
chrome/browser/google_apis/gdata_wapi_url_util.cc:108: if
(directory_resource_id.empty()) {
On 2012/11/20 06:07:35, hashimoto wrote:
> How about putting start_changestamp > 0 case before start_changestamp == 0
case?
> This way, we can reduce the indent level of if
(directory_resource_id.empty()).

good idea. done.

[hashimoto, 2012-11-20 06:16:06]

lgtm

http://codereview.chromium.org/11316097/diff/12002/chrome/browser/google_apis...
File chrome/browser/google_apis/gdata_wapi_url_util.cc (right):

http://codereview.chromium.org/11316097/diff/12002/chrome/browser/google_apis...
chrome/browser/google_apis/gdata_wapi_url_util.cc:107: } else if
(start_changestamp > 0) {
Ah, sorry, '!= 0' and DCHECK_LE(0, start_changestamp) seems better because we
can save one line :)
Anyways, it's up to you.

[satorux1, 2012-11-20 06:27:33]

http://codereview.chromium.org/11316097/diff/12002/chrome/browser/google_apis...
File chrome/browser/google_apis/gdata_wapi_url_util.cc (right):

http://codereview.chromium.org/11316097/diff/12002/chrome/browser/google_apis...
chrome/browser/google_apis/gdata_wapi_url_util.cc:107: } else if
(start_changestamp > 0) {
On 2012/11/20 06:16:06, hashimoto wrote:
> Ah, sorry, '!= 0' and DCHECK_LE(0, start_changestamp) seems better because we
> can save one line :)
> Anyways, it's up to you.

Added a DCHECK at the beginning of the function.

[hashimoto, 2012-11-20 06:28:31]

lgtm++, thanks