Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Issue 11316090: [Spellcheck] Cleanup. Resubmit, again (Closed)

Created:
8 years, 1 month ago by groby-ooo-7-16
Modified:
8 years ago
Reviewers:
rpetterson, sky
CC:
chromium-reviews, groby+spellwatch_chromium.org, rpetterson, darin-cc_chromium.org, sail+watch_chromium.org
Visibility:
Public.

Description

[Spellcheck] Cleanup. Resubmit, again Completely unmodified resubmit of https://codereview.chromium.org/11361265/ Actual bug causing previous submission to fail is fixed in https://codereview.chromium.org/11413054/ TBR=rlp@chromium.org,sky@chromium.org BUG=154918 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170983

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -95 lines) Patch
M chrome/renderer/chrome_content_renderer_client.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 chunk +10 lines, -5 lines 0 comments Download
M chrome/renderer/spellchecker/cocoa_spelling_engine_mac.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/renderer/spellchecker/cocoa_spelling_engine_mac.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/renderer/spellchecker/hunspell_engine.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck.h View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck.cc View 6 chunks +7 lines, -22 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_provider.cc View 8 chunks +27 lines, -60 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_provider_test.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_unittest.cc View 4 chunks +16 lines, -4 lines 0 comments Download
M chrome/renderer/spellchecker/spelling_engine.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/test/base/chrome_render_view_test.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
rpetterson
Not sure you need my LGTM since it's just a resubmit, but there you go ...
8 years ago (2012-11-26 19:17:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/11316090/1
8 years ago (2012-12-03 19:08:48 UTC) #2
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests
8 years ago (2012-12-03 23:45:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/11316090/1
8 years ago (2012-12-04 02:16:55 UTC) #4
commit-bot: I haz the power
8 years ago (2012-12-04 05:42:15 UTC) #5
Retried try job too often on win_rel for step(s) browser_tests

Powered by Google App Engine
This is Rietveld 408576698