Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: tests/standalone/io/file_non_ascii_test.dart

Issue 11316077: Remove non-ascii file names from repo and generate them in tests instead. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Remove last file Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/standalone/io/file_non_ascii_test.dart
diff --git a/tests/standalone/io/file_non_ascii_test.dart b/tests/standalone/io/file_non_ascii_test.dart
index d08208069a489f5880f1b687698745de9f061a80..a2228dbbd2abfba3d2ee1bd368657fcb8d8fff6f 100644
--- a/tests/standalone/io/file_non_ascii_test.dart
+++ b/tests/standalone/io/file_non_ascii_test.dart
@@ -6,28 +6,46 @@ import 'dart:io';
import 'dart:isolate';
main() {
- var port = new ReceivePort();
- Directory scriptDir = new File(new Options().script).directorySync();
- var f = new File("${scriptDir.path}/æøå/æøå.dat");
+ ReceivePort port = new ReceivePort();
+
// On MacOS you get the decomposed utf8 form of file and directory
// names from the system. Therefore, we have to check for both here.
var precomposed = 'æøå';
var decomposed = new String.fromCharCodes([47, 230, 248, 97, 778]);
- f.exists().then((e) {
- Expect.isTrue(e);
- f.create().then((_) {
- f.directory().then((d) {
- Expect.isTrue(d.path.endsWith(precomposed) ||
- d.path.endsWith(decomposed));
- f.length().then((l) {
- Expect.equals(6, l);
- f.lastModified().then((_) {
- f.fullPath().then((p) {
- Expect.isTrue(p.endsWith('${precomposed}.dat') ||
- p.endsWith('${decomposed}.dat'));
- f.readAsString().then((contents) {
- Expect.equals(precomposed, contents);
- port.close();
+
+ new Directory('').createTemp().then((tempDir) {
+ Directory nonAsciiDir = new Directory('${tempDir.path}/æøå');
+ nonAsciiDir.create().then((nonAsciiDir) {
+ nonAsciiDir.exists().then((result) {
+ Expect.isTrue(result);
+ File nonAsciiFile = new File('${nonAsciiDir.path}/æøå.txt');
+ nonAsciiFile.open(FileMode.WRITE).then((opened) {
+ opened.writeString('æøå').then((_) {
+ opened.close().then((_) {
+ nonAsciiFile.exists().then((result) {
+ Expect.isTrue(result);
+ nonAsciiFile.readAsString().then((contents) {
+ // The contents of the file is precomposed utf8.
+ Expect.equals(precomposed, contents);
+ nonAsciiFile.create().then((_) {
+ nonAsciiFile.directory().then((d) {
+ Expect.isTrue(d.path.endsWith(precomposed) ||
+ d.path.endsWith(decomposed));
+ nonAsciiFile.length().then((l) {
ricow1 2012/11/19 12:20:54 l -> length?
Mads Ager (google) 2012/11/19 12:26:20 Done.
+ Expect.equals(6, l);
+ nonAsciiFile.lastModified().then((_) {
+ nonAsciiFile.fullPath().then((path) {
+ Expect.isTrue(path.endsWith('${precomposed}.txt') ||
+ path.endsWith('${decomposed}.txt'));
+ tempDir.delete(recursive: true).then((_) {
+ port.close();
+ });
+ });
+ });
+ });
+ });
+ });
+ });
});
});
});

Powered by Google App Engine
This is Rietveld 408576698