Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Unified Diff: tests/standalone/io/directory_non_ascii_sync_test.dart

Issue 11316077: Remove non-ascii file names from repo and generate them in tests instead. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Remove last file Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/standalone/io/directory_non_ascii_sync_test.dart
diff --git a/tests/standalone/io/directory_non_ascii_sync_test.dart b/tests/standalone/io/directory_non_ascii_sync_test.dart
index bbcf4c7e86584e44585b566beafb21370fc46c39..217b2175d56094e02f845ddaf7c1b14496516cfa 100644
--- a/tests/standalone/io/directory_non_ascii_sync_test.dart
+++ b/tests/standalone/io/directory_non_ascii_sync_test.dart
@@ -5,18 +5,18 @@
import 'dart:io';
main() {
- Directory scriptDir = new File(new Options().script).directorySync();
- var d = new Directory("${scriptDir.path}/æøå");
+ Directory tempDir = new Directory('').createTempSync();
+ var d = new Directory("${tempDir.path}/æøå");
// On MacOS you get the decomposed utf8 form of file and directory
// names from the system. Therefore, we have to check for both here.
var precomposed = 'æøå';
var decomposed = new String.fromCharCodes([47, 230, 248, 97, 778]);
- Expect.isTrue(d.existsSync());
+ Expect.isFalse(d.existsSync());
d.createSync();
- var temp = new Directory('').createTempSync();
- var temp2 = new Directory("${temp.path}/æøå").createTempSync();
+ Expect.isTrue(d.existsSync());
+ var temp2 = new Directory("${tempDir.path}/æøå").createTempSync();
Expect.isTrue(temp2.path.contains(precomposed) ||
temp2.path.contains(decomposed));
temp2.deleteSync();
- temp.deleteSync(recursive: true);
+ tempDir.deleteSync(recursive: true);
ricow1 2012/11/19 12:20:54 maybe assert that the two paths does not still exi
Mads Ager (google) 2012/11/19 12:26:20 Renamed: d -> nonAsciiDir temp2 -> temp Added ass
}
« no previous file with comments | « no previous file | tests/standalone/io/directory_non_ascii_test.dart » ('j') | tests/standalone/io/directory_non_ascii_test.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698