Make it so the windows store protocol is properly handled

chrome/browser/platform_util_win.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/platform_util.h"
 
 #include <commdlg.h>
 #include <dwmapi.h>
 #include <shellapi.h>
 #include <shlobj.h>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/logging.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "base/win/registry.h"
 #include "base/win/scoped_co_mem.h"
 #include "base/win/scoped_comptr.h"
+#include "base/win/windows_version.h"
 #include "content/public/browser/browser_thread.h"
 #include "googleurl/src/gurl.h"
 #include "ui/base/win/shell.h"
 #include "ui/gfx/native_widget_types.h"
 
 using content::BrowserThread;
 
 namespace {
 
 void ShowItemInFolderOnFileThread(const FilePath& full_path) {
@@ skipping 74 matching lines @@
                    << "(): Can't open full_path = \""
                    << full_path.value() << "\""
                    << " hr = " << hr
                    << " " << reinterpret_cast<LPTSTR>(&message);
       if (message)
         LocalFree(message);
     }
   }
 }
 
+// Old ShellExecute crashes the process when the command for a given scheme
+// is empty. This function tells if it is.
+bool ValidateShellCommandForScheme(const std::string& scheme) {
+  base::win::RegKey key;
+  std::wstring registry_path = ASCIIToWide(scheme) +
+                               L"\\shell\\open\\command";
+  key.Open(HKEY_CLASSES_ROOT, registry_path.c_str(), KEY_READ);
+  if (!key.Valid())
+    return false;
+  DWORD size = 0;
+  key.ReadValue(NULL, NULL, &size, NULL);
+  if (size <= 2)
+      return false;

[darin (slow to review), 2013/01/08 06:00:14]

nit: 2 space indent

[cpu_(ooo_6.6-7.5), 2013/01/08 19:01:16]

Done.

+  return true;
+}
 }  // namespace

[darin (slow to review), 2013/01/08 06:00:14]

nit: new line before close of namespace

[cpu_(ooo_6.6-7.5), 2013/01/08 19:01:16]

Done.

 
 namespace platform_util {
 
 void ShowItemInFolder(const FilePath& full_path) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   BrowserThread::PostTask(BrowserThread::FILE, FROM_HERE,
       base::Bind(&ShowItemInFolderOnFileThread, full_path));
 }
 
 void OpenItem(const FilePath& full_path) {
@@ skipping 14 matching lines @@
   // According to Mozilla in uriloader/exthandler/win/nsOSHelperAppService.cpp:
   // "Some versions of windows (Win2k before SP3, Win XP before SP1) crash in
   // ShellExecute on long URLs (bug 161357 on bugzilla.mozilla.org). IE 5 and 6
   // support URLS of 2083 chars in length, 2K is safe."
   const size_t kMaxUrlLength = 2048;
   if (escaped_url.length() > kMaxUrlLength) {
     NOTREACHED();
     return;
   }
 
-  base::win::RegKey key;
-  std::wstring registry_path = ASCIIToWide(url.scheme()) +
-                               L"\\shell\\open\\command";
-  key.Open(HKEY_CLASSES_ROOT, registry_path.c_str(), KEY_READ);
-  if (key.Valid()) {
-    DWORD size = 0;
-    key.ReadValue(NULL, NULL, &size, NULL);
-    if (size <= 2) {
-      // ShellExecute crashes the process when the command is empty.
-      // We check for "2" because it always returns the trailing NULL.
-      // TODO(nsylvain): we should also add a dialog to warn on errors. See
-      // bug 1136923.
+  if (base::win::GetVersion() < base::win::VERSION_WIN7) {

[darin (slow to review), 2013/01/08 06:00:14]

Why less than Win7 and not less than Win8?  Win7 also supports the
DelegateExecute method?

[cpu_(ooo_6.6-7.5), 2013/01/08 19:01:16]

Yes.

+    if (!ValidateShellCommandForScheme(url.scheme()))

[jschuh, 2013/01/08 04:06:00]

I feel like Nicolas should sign off on this one given the original bug.

[cpu_(ooo_6.6-7.5), 2013/01/08 19:01:16]

Ok, I'll ping him.

[jschuh, 2013/01/08 19:22:37]

I'm pretty sure I typed that after you handed me a tequila. Please disregard.

       return;
-    }
   }
 
   if (reinterpret_cast<ULONG_PTR>(ShellExecuteA(NULL, "open",
                                                 escaped_url.c_str(), NULL, NULL,
                                                 SW_SHOWNORMAL)) <= 32) {
     // We fail to execute the call. We could display a message to the user.
     // TODO(nsylvain): we should also add a dialog to warn on errors. See
     // bug 1136923.
     return;
   }
@@ skipping 16 matching lines @@
   ::SetForegroundWindow(window);
 }
 
 bool IsVisible(gfx::NativeView view) {
   // MSVC complains if we don't include != 0.
   return ::IsWindowVisible(view) != 0;
 }
 #endif
 
 }  // namespace platform_util