cc: Create cc::DebugColors class to hold all the debugging color/width constants.

cc: Create cc::DebugColors class to hold all the debugging color/width constants.

This class has a bunch of static methods that provide colors and widths of
debugging visualizations. It also will make things wider based on the current
device scale factor, when it is available.

R=enne
BUG=160867
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=168087

[tfarina, 2012-11-15 21:06:10]

https://codereview.chromium.org/11316026/diff/1/cc/debug_colors.h
File cc/debug_colors.h (right):

https://codereview.chromium.org/11316026/diff/1/cc/debug_colors.h#newcode16
cc/debug_colors.h:16: static SkColor kTiledContentLayerBorderColor();
was the use of 'k' prefix intentional?

https://codereview.chromium.org/11316026/diff/1/cc/debug_colors.h#newcode17
cc/debug_colors.h:17: static int     kTiledContentLayerBorderWidth(const
LayerTreeHostImpl* hostImpl);
if this were to follow chromium style then three minor points:

1- only one space after 'int'
2- s/hostImpl/host_impl
3- respect the 80 char columns.

https://codereview.chromium.org/11316026/diff/1/cc/debug_colors.h#newcode45
cc/debug_colors.h:45: };
DISALLOW_IMPLICIT_CONSTRUCTORS

[danakj, 2012-11-15 21:11:34]

https://codereview.chromium.org/11316026/diff/1/cc/debug_colors.h
File cc/debug_colors.h (right):

https://codereview.chromium.org/11316026/diff/1/cc/debug_colors.h#newcode16
cc/debug_colors.h:16: static SkColor kTiledContentLayerBorderColor();
On 2012/11/15 21:06:10, tfarina wrote:
> was the use of 'k' prefix intentional?

oh.. i had made them constants before. I'll fix the names, thanks.

https://codereview.chromium.org/11316026/diff/1/cc/debug_colors.h#newcode45
cc/debug_colors.h:45: };
On 2012/11/15 21:06:10, tfarina wrote:
> DISALLOW_IMPLICIT_CONSTRUCTORS

ah.. fancy.

[enne (OOO), 2012-11-15 21:32:08]

lgtm

[commit-bot: I haz the power, 2012-11-15 21:50:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/11316026/4002