Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(846)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/telemetry/telemetry/page.py

Issue 11316017: Refactoring scrolling_benchmark code into scrolling_interaction.py (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Trying out marja's suggestion Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/perf/page_sets/top_25.json ('K') | « tools/perf/perf_tools/scrolling_benchmark.py ('k') | tools/telemetry/telemetry/scrolling_interaction.py » ('j') | tools/telemetry/telemetry/scrolling_interaction.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page.py
diff --git a/tools/telemetry/telemetry/page.py b/tools/telemetry/telemetry/page.py
index 122e62b29a8ad7884bbf4801e5fd1e394bae5d24..a637fe634be38a793a5b91eb9fce30423a9e7092 100644
--- a/tools/telemetry/telemetry/page.py
+++ b/tools/telemetry/telemetry/page.py
@@ -15,9 +15,9 @@ class Page(object):
raise Exception('URLs must be fully qualified: %s' % url)
self.url = url
self.interactions = 'scroll'
marja 2012/11/16 13:28:34 Can this be removed, too? What is this for in the
hartmanng 2012/11/16 16:19:24 Done.
+ self.scroll_results = None
self.credentials = None
self.wait_time_after_navigate = 2
- self.scroll_is_infinite = False
self.wait_for_javascript_expression = None
if attributes:
« tools/perf/page_sets/top_25.json ('K') | « tools/perf/perf_tools/scrolling_benchmark.py ('k') | tools/telemetry/telemetry/scrolling_interaction.py » ('j') | tools/telemetry/telemetry/scrolling_interaction.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698