Issue 1131583002: Revert of New insertion write barrier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1131583002: Revert of New insertion write barrier. (Closed)

Created:
5 years, 7 months ago by Hannes Payer (out of office)

Modified:
5 years, 7 months ago

Reviewers:
ulan, Erik Corry Chromium.org

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Revert of New insertion write barrier. (patchset #3 id:200001 of https://codereview.chromium.org/1073953006/) Reason for revert: Various performance regressions. Original issue's description: > New insertion write barrier. > > BUG= > > Committed: https://crrev.com/6e9e2c08292b553602c74b16b8ccff4e4ccac003 > Cr-Commit-Position: refs/heads/master@{#28199} TBR=ulan@chromium.org,erikcorry@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/74654d309816211964c7bac528a6c263aa54a475 Cr-Commit-Position: refs/heads/master@{#28265}

Created: 5 years, 7 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -2 lines)			Patch
	M	src/heap/incremental-marking-inl.h	View		1 chunk	+18 lines, -2 lines	0 comments	Download
	M	src/heap/spaces.h	View		1 chunk	+7 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Hannes Payer (out of office)

Created Revert of New insertion write barrier.

5 years, 7 months ago (2015-05-06 14:34:44 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131583002/1

5 years, 7 months ago (2015-05-06 14:34:58 UTC) #2

commit-bot: I haz the power

5 years, 7 months ago (2015-05-06 14:35:19 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/74654d309816211964c7bac528a6c263aa54a475
Cr-Commit-Position: refs/heads/master@{#28265}