src/arm64/macro-assembler-arm64.h - Issue 1131573006: ARM64: Enable shorten-64-to-32 warning

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm64/macro-assembler-arm64.h

Issue 1131573006: ARM64: Enable shorten-64-to-32 warning (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/arm64/macro-assembler-arm64.h

diff --git a/src/arm64/macro-assembler-arm64.h b/src/arm64/macro-assembler-arm64.h

index 1160c40bf609ebf48d65cdf6e4c3c46c442a0d89..7854ff0e520987e4683847ba921d2d77a7e16188 100644

--- a/src/arm64/macro-assembler-arm64.h

+++ b/src/arm64/macro-assembler-arm64.h

@@ -886,8 +886,8 @@ class MacroAssembler : public Assembler {

template<typename Field>

void DecodeField(Register dst, Register src) {

- static const uint64_t shift = Field::kShift;

- static const uint64_t setbits = CountSetBits(Field::kMask, 32);

+ static const int shift = Field::kShift;

+ static const int setbits = CountSetBits(Field::kMask, 32);

Ubfx(dst, src, shift, setbits);

}

« no previous file with comments | « src/arm64/lithium-codegen-arm64.cc ('k') | src/arm64/macro-assembler-arm64.cc » ('j') | no next file with comments »