DescriptionRevert of Use cert config options in SSLServerSocketOpenSSL. (patchset #4 id:80001 of https://codereview.chromium.org/1138813003/)
Reason for revert:
It seems like this change has caused new leaks on Linux and ChromeOS.
First build it appeared: http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%281%29/builds/41241
Log output:
Memcheck:Leak
fun:calloc
fun:PORT_ZAlloc_Util
fun:ConvertToSID
fun:ServerSessionIDLookup
fun:ssl3_HandleClientHello
fun:ssl3_HandleHandshakeMessage
fun:ssl3_HandleHandshake
fun:ssl3_HandleRecord
fun:ssl3_GatherCompleteHandshake
fun:SSL_ForceHandshake
fun:_ZN3net18SSLServerSocketNSS11DoHandshakeEv
fun:_ZN3net18SSLServerSocketNSS15DoHandshakeLoopEi
fun:_ZN3net18SSLServerSocketNSS21OnHandshakeIOCompleteEi
fun:_ZN3net18SSLServerSocketNSS14OnRecvCompleteEi
fun:_ZN3net18SSLServerSocketNSS18BufferRecvCompleteEi
This might be tickling some bug in underlying libraries, or it might be a problem with the change itself.
You can reproduce the leak by running valgrind and running all the SSLServerSocket tests. I didn't narrow down which test.
See https://www.chromium.org/developers/how-tos/using-valgrind for more details on using valgrind.
Original issue's description:
> Use cipher suite config options in SSLServerSocketOpenSSL.
>
> Previously SSLServerSocketOpenSSL was ignoring disabled_cipher_suites
> list and require_forward_secrecy flag from SSLConfig. Fixed
> SSLServerSocketOpenSSL to trim the list of cipher suites used in BoringSSL.
>
> BUG=481163
>
> Committed: https://crrev.com/d0eae58087e6f45088d6ef349d9ebaa2da450ea1
> Cr-Commit-Position: refs/heads/master@{#329528}
TBR=davidben@chromium.org,sergeyu@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=481163
Committed: https://crrev.com/d0f1ada67a97c7cfa29cea88ee4b5b07e6aeb86d
Cr-Commit-Position: refs/heads/master@{#329594}
Patch Set 1 #
Created: 5 years, 7 months ago
(Patch set is too large to download)
Messages
Total messages: 4 (0 generated)
|