src/gpu/GrBatch.cpp - Issue 1131553002: Isolate GrBufferAllocPools inside GrBatchTarget

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/GrBatch.cpp

Issue 1131553002: Isolate GrBufferAllocPools inside GrBatchTarget (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: minor cleanup Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/GrBatch.cpp

diff --git a/src/gpu/GrBatch.cpp b/src/gpu/GrBatch.cpp

index 7d1c0ae25fb1c14b7a623187a56cc8a38301c69a..0655a4cd9db6f63e6ad7abc5134c8e56d2ece1f6 100644

--- a/src/gpu/GrBatch.cpp

+++ b/src/gpu/GrBatch.cpp

@@ -58,8 +58,8 @@ void* GrBatch::InstancedHelper::init(GrBatchTarget* batchTarget, GrPrimitiveType

const GrVertexBuffer* vertexBuffer;

int firstVertex;

int vertexCount = verticesPerInstance * instancesToDraw;

- void* vertices = batchTarget->vertexPool()->makeSpace(vertexStride, vertexCount, &vertexBuffer,

- &firstVertex);

+ void* vertices = batchTarget->makeVertSpace(vertexStride, vertexCount,

+ &vertexBuffer, &firstVertex);

if (!vertices) {

SkDebugf("Vertices could not be allocated for instanced rendering.");

return NULL;