Issue 1131543002: Add TODO to implement 'bookmarking' for the streaming stream.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1131543002: Add TODO to implement 'bookmarking' for the streaming stream. (Closed)

Created:
5 years, 7 months ago by vogelheim

Modified:
5 years, 7 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Add TODO to implement 'bookmarking' for the streaming stream. (This implementation is used in streaming parsing. Fixing this will probably require changing the V8/embedder interface and will take some more time. The TODO was requested in the crrev.com/1102523003 review, but I somehow dropped this.) BUG=chromium:470930 LOG=N R=jochen@chromium.org

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	src/scanner-character-streams.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

jochen (gone - plz use gerrit)

does that mean that bookmarking does not work if we're running the tests in a ...

5 years, 7 months ago (2015-05-07 11:48:41 UTC) #1

Closing. Obsoleted by crrev.com/1156733002.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages