Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 113153002: Revert "Moved GL enums from GraphicsContext3D to a more generic location." (Closed)

Created:
7 years ago by adamk
Modified:
7 years ago
Reviewers:
bajones
CC:
blink-reviews, aandrey+blink_chromium.org, dglazkov+blink, Rik, adamk+blink_chromium.org
Visibility:
Public.

Description

Revert "Moved GL enums from GraphicsContext3D to a more generic location." This reverts commit db4863b848c80f914932f1f1cff4276890ae0d98. It broke the Android build: WebMediaPlayerClientImpl.cpp: In member function 'void blink::WebMediaPlayerClientImpl::paintOnAndroid(...)': WebMediaPlayerClientImpl.cpp:597:98:error: 'RGBA' is not a member of 'WebCore::GraphicsContext3D' WebMediaPlayerClientImpl.cpp:597:123:error: 'UNSIGNED_BYTE' is not a member of 'WebCore::GraphicsContext3D' TBR=bajones@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163726

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1394 lines, -1087 lines) Patch
M Source/core/html/canvas/OESVertexArrayObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/WebGLBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/WebGLDrawBuffers.cpp View 4 chunks +24 lines, -24 lines 0 comments Download
M Source/core/html/canvas/WebGLFramebuffer.cpp View 16 chunks +70 lines, -72 lines 0 comments Download
M Source/core/html/canvas/WebGLObject.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/canvas/WebGLProgram.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M Source/core/html/canvas/WebGLRenderbuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/WebGLRenderingContext.cpp View 155 chunks +703 lines, -704 lines 0 comments Download
M Source/core/html/canvas/WebGLTexture.cpp View 6 chunks +39 lines, -39 lines 0 comments Download
M Source/core/html/canvas/WebGLVertexArrayObjectOES.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/graphics/Canvas2DLayerBridge.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/platform/graphics/Extensions3D.h View 1 chunk +7 lines, -0 lines 0 comments Download
M Source/platform/graphics/Extensions3D.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/graphics/GraphicsContext3D.h View 2 chunks +314 lines, -2 lines 0 comments Download
M Source/platform/graphics/GraphicsContext3D.cpp View 11 chunks +57 lines, -57 lines 0 comments Download
M Source/platform/graphics/GraphicsContext3DImagePacking.cpp View 3 chunks +23 lines, -23 lines 0 comments Download
M Source/platform/graphics/GraphicsTypes3D.h View 2 chunks +2 lines, -10 lines 0 comments Download
M Source/platform/graphics/ImageBuffer.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/graphics/filters/custom/CustomFilterCompiledProgram.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/graphics/filters/custom/CustomFilterGlobalContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/filters/custom/CustomFilterMesh.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/platform/graphics/filters/custom/CustomFilterRenderer.cpp View 4 chunks +10 lines, -10 lines 0 comments Download
M Source/platform/graphics/filters/custom/FECustomFilter.cpp View 9 chunks +29 lines, -29 lines 0 comments Download
M Source/platform/graphics/gpu/DrawingBuffer.cpp View 20 chunks +75 lines, -75 lines 0 comments Download
M Source/web/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/tests/DrawingBufferTest.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/web/tests/MockWebGraphicsContext3D.h View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
adamk
7 years ago (2013-12-11 20:33:50 UTC) #1
adamk
7 years ago (2013-12-11 20:42:09 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r163726.

Powered by Google App Engine
This is Rietveld 408576698